Re: [PATCH flutter-frontend v2 1/2] fix #4281: android: register OpenID Connect callback activity

["Shan Shaji" <s.shaji@proxmox.com>]

On Mon Aug 10, 2026 at 4:47 PM CEST, Azharul Haque wrote:
> proxmox_login_manager's OpenID login flow (see the corresponding
> patch there) opens the provider's authorization URL via
> flutter_web_auth_2 and expects the provider's redirect back to
> pveauth://openid-callback to be captured by the app. On Android this

  ^-- IMHO, the new scheme could be added in this patch itself. That way
  the PATCH flutter-frontend 2/2 can be dropped. 

> requires explicitly registering flutter_web_auth_2's CallbackActivity
> for that scheme; add it, following the plugin's setup instructions.
> Also set android:taskAffinity="" on both activities as recommended
> for this flutter_web_auth_2 version, to avoid a stray task appearing
> after the callback returns control to MainActivity.
>
> No changes needed on iOS: ASWebAuthenticationSession handles the
> custom-scheme redirect without any Info.plist registration.
>
> linux/flutter/generated_plugin_registrant.cc, generated_plugins.cmake
> and pubspec.lock are regenerated as a consequence of the new
> transitive dependency on flutter_web_auth_2 (and, on Linux/Windows,
> its desktop_webview_window fallback).

I think it would be better to seperate the android .xml config changes
and the generated changes into its own separate patches. 

>
> Signed-off-by: Azharul Haque <haque@azharul.com>
> ---
>  android/app/src/main/AndroidManifest.xml     |  16 ++
>  linux/flutter/generated_plugin_registrant.cc |   8 +
>  linux/flutter/generated_plugins.cmake        |   2 +
>  pubspec.lock                                 | 184 +++++++++++--------
>  4 files changed, 138 insertions(+), 72 deletions(-)
>
> diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
> index 66135eb..884fedd 100644
> --- a/android/app/src/main/AndroidManifest.xml
> +++ b/android/app/src/main/AndroidManifest.xml
> @@ -12,6 +12,7 @@
>              android:name="com.proxmox.app.pve_flutter_frontend.MainActivity"
>              android:exported="true"
>              android:launchMode="singleTop"
> +            android:taskAffinity=""
>              android:theme="@style/LaunchTheme"
>              android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"
>              android:hardwareAccelerated="true"
> @@ -23,6 +24,21 @@
>              </intent-filter>
>          </activity>
>  
> +        <!-- Captures the OpenID Connect provider's redirect back into the app
> +             for realms configured with an OAuth/OIDC login, see
> +             flutter_web_auth_2 and ProxmoxLoginForm's OpenID login flow. -->
> +        <activity
> +            android:name="com.linusu.flutter_web_auth_2.CallbackActivity"
> +            android:exported="true"
> +            android:taskAffinity="">
> +            <intent-filter android:label="flutter_web_auth_2">
> +                <action android:name="android.intent.action.VIEW" />
> +                <category android:name="android.intent.category.DEFAULT" />
> +                <category android:name="android.intent.category.BROWSABLE" />
> +                <data android:scheme="pveauth" />

This config changes can itself be another patch. 

> +            </intent-filter>
> +        </activity>
> +
>          <!-- This is used by Flutter to generate GeneratedPluginRegistrant.java -->
>          <meta-data
>              android:name="flutterEmbedding"

[snip]

>  sdks:
> -  dart: ">=3.10.3 <4.0.0"
> -  flutter: ">=3.38.4"
> +  dart: ">=3.12.0 <4.0.0"
> +  flutter: ">=3.44.0"

As I mentioned in my previous reply we are using flutter v3.41