From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D10011FF0A8 for ; Thu, 20 Aug 2026 16:01:24 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6EF9C215C8; Thu, 20 Aug 2026 16:01:21 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 20 Aug 2026 16:01:15 +0200 Message-Id: Subject: Re: [PATCH flutter-frontend v2 1/2] fix #4281: android: register OpenID Connect callback activity From: "Shan Shaji" To: "Azharul Haque" , X-Mailer: aerc 0.20.0 References: <20260810144713.75806-1-haque@azharul.com> <20260810144713.75806-7-haque@azharul.com> In-Reply-To: <20260810144713.75806-7-haque@azharul.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787234449954 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.591 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HLDGFXVTWI4ZVCM4H4RBMUKRIA3I5BQG X-Message-ID-Hash: HLDGFXVTWI4ZVCM4H4RBMUKRIA3I5BQG X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Aug 10, 2026 at 4:47 PM CEST, Azharul Haque wrote: > proxmox_login_manager's OpenID login flow (see the corresponding > patch there) opens the provider's authorization URL via > flutter_web_auth_2 and expects the provider's redirect back to > pveauth://openid-callback to be captured by the app. On Android this ^-- IMHO, the new scheme could be added in this patch itself. That way the PATCH flutter-frontend 2/2 can be dropped.=20 > requires explicitly registering flutter_web_auth_2's CallbackActivity > for that scheme; add it, following the plugin's setup instructions. > Also set android:taskAffinity=3D"" on both activities as recommended > for this flutter_web_auth_2 version, to avoid a stray task appearing > after the callback returns control to MainActivity. > > No changes needed on iOS: ASWebAuthenticationSession handles the > custom-scheme redirect without any Info.plist registration. > > linux/flutter/generated_plugin_registrant.cc, generated_plugins.cmake > and pubspec.lock are regenerated as a consequence of the new > transitive dependency on flutter_web_auth_2 (and, on Linux/Windows, > its desktop_webview_window fallback). I think it would be better to seperate the android .xml config changes and the generated changes into its own separate patches.=20 > > Signed-off-by: Azharul Haque > --- > android/app/src/main/AndroidManifest.xml | 16 ++ > linux/flutter/generated_plugin_registrant.cc | 8 + > linux/flutter/generated_plugins.cmake | 2 + > pubspec.lock | 184 +++++++++++-------- > 4 files changed, 138 insertions(+), 72 deletions(-) > > diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/m= ain/AndroidManifest.xml > index 66135eb..884fedd 100644 > --- a/android/app/src/main/AndroidManifest.xml > +++ b/android/app/src/main/AndroidManifest.xml > @@ -12,6 +12,7 @@ > android:name=3D"com.proxmox.app.pve_flutter_frontend.MainAct= ivity" > android:exported=3D"true" > android:launchMode=3D"singleTop" > + android:taskAffinity=3D"" > android:theme=3D"@style/LaunchTheme" > android:configChanges=3D"orientation|keyboardHidden|keyboard= |screenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode" > android:hardwareAccelerated=3D"true" > @@ -23,6 +24,21 @@ > > > =20 > + > + + android:name=3D"com.linusu.flutter_web_auth_2.CallbackActivi= ty" > + android:exported=3D"true" > + android:taskAffinity=3D""> > + > + > + > + > + This config changes can itself be another patch.=20 > + > + > + > > android:name=3D"flutterEmbedding" [snip] > sdks: > - dart: ">=3D3.10.3 <4.0.0" > - flutter: ">=3D3.38.4" > + dart: ">=3D3.12.0 <4.0.0" > + flutter: ">=3D3.44.0" As I mentioned in my previous reply we are using flutter v3.41