From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A770E1FF0C1 for ; Wed, 26 Aug 2026 13:41:10 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E26E521425; Wed, 26 Aug 2026 13:41:09 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 26 Aug 2026 13:41:05 +0200 Message-Id: Subject: Re: [PATCH v3 00/10] app: implement OpenID Connect (OAuth) realm login (#4281) From: "Shan Shaji" To: "Azharul Haque" , X-Mailer: aerc 0.20.0 References: <20260810144713.75806-1-haque@azharul.com> <20260821034147.30194-1-haque@azharul.com> In-Reply-To: <20260821034147.30194-1-haque@azharul.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787744457431 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.528 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LKO4NJU5VKYSXAARZMHV35CGPKR3QTWQ X-Message-ID-Hash: LKO4NJU5VKYSXAARZMHV35CGPKR3QTWQ X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Azharul, Please don't send a v4 promptly, as I am doing another round of testing. I will get back once I am done with the testing and code review. Also, Sorr= y for not mentioning about the continue button issue in my v2 reviews. On Fri Aug 21, 2026 at 5:41 AM CEST, Azharul Haque wrote: > The native Flutter "Proxmox VE Companion" app never implemented OpenID > Connect / OAuth realm login (bug #4281[0]): selecting an OAuth realm > just showed username/password fields that could never work. > > v3: addresses review feedback on v2, still as a single combined series > across the three affected repositories: > > - dart-api-client: PveAccessDomainModel.type is now a built_value > EnumClass (PveAccessDomainType) instead of a plain String, and the > OpenID ticket-parsing helper's regex/dedup issue is fixed. > - login-manager: the single large "add OpenID Connect login flow" > patch is split into five, dependency, _finishLogin refactor, > password-form widget extraction, the OpenID feature itself, and > the pre-existing Continue-button fix, and print()/print(trace) > calls copied into the new OpenID error handling are removed. > - flutter-frontend: the manifest change is split into three, > generated-file regeneration, the taskAffinity tweak, and the > CallbackActivity registration itself. > - Both repos' "rename the callback scheme" follow-up patches from v2 > are gone entirely: the final scheme (com.proxmox.app, further > shortened per your follow-up on the login-manager v2 3/3 patch) is > now introduced directly wherever it first appears. > - All lockfiles/generated files are regenerated against Flutter > 3.41 / Dart 3.11 to match this project's toolchain, rather than > the newer local Flutter version v2 was inadvertently built with. > > Verified end-to-end against a real PVE server with an Authentik OIDC > realm, on both Android and iOS, plus flutter analyze/test/format under > Flutter 3.41 across all three repos, plus a real Android Gradle build > of the modified manifest. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=3D4281 > > Azharul Haque (10): > fix #4281: access: add `type` property to `PveAccessDomainModel` > fix #4281: access: add OpenID Connect auth-url/login helpers > fix #4281: deps: add flutter_web_auth_2 dependency > refactor: ui: factor out shared login tail into _finishLogin > refactor: ui: split password form into its own widget > fix #4281: ui: add OpenID Connect login flow to login form > fix #4281: ui: fix stale Continue button state on realm switch > chore: regenerate plugin registrant for flutter_web_auth_2 > fix #4281: android: set taskAffinity=3D"" on MainActivity > fix #4281: android: register OpenID Connect callback activity > > -- > 2.50.1 (Apple Git-155)