Re: [PATCH pve-manager v4 16/17] ui: cpu flags selector: add search bar for large lists of flags

[Fiona Ebner <f.ebner@proxmox.com>]

Am 04.05.26 um 7:46 AM schrieb Arthur Bied-Charreton:
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index ef9555e6..6c9437b7 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -70,7 +70,11 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>  
>          let flags = '';
>  
> -        store.getData().each(function (rec) {
> +        // Get the values directly from the data source. Using store.getData() here
> +        // would iterate over the filtered values, potentially overwriting flags that
> +        // are set but currently filtered out by the search bar.
> +        let source = store.getDataSource();
> +        source.each(function (rec) {

Don't we have to do the same for the other usage of store.getData() for
clearing the previous unknown flags?

---snip 8<---

> +        if (!me.restrictToVMFlags) {
> +            topToolbarItems.push('-', {
> +                xtype: 'textfield',
> +                emptyText: gettext('Search...'),

Nit: seems like we use 'Search' without the dots in other places.