From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id AE86E1FF133
	for <inbox@lore.proxmox.com>; Mon, 11 May 2026 15:56:50 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id F27661B82F;
	Mon, 11 May 2026 15:56:48 +0200 (CEST)
Message-ID: <fd843f5a-7999-4956-a5ac-b0bdd2aa9428@proxmox.com>
Date: Mon, 11 May 2026 15:56:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH pve-manager v4 16/17] ui: cpu flags selector: add search
 bar for large lists of flags
To: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>,
 pve-devel@lists.proxmox.com
References: <20260430160109.565536-1-a.bied-charreton@proxmox.com>
 <20260430160109.565536-17-a.bied-charreton@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20260430160109.565536-17-a.bied-charreton@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1778507693068
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.009 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: TMTAU7RMKWAPSG32L2IAGMZDS3F5E4SU
X-Message-ID-Hash: TMTAU7RMKWAPSG32L2IAGMZDS3F5E4SU
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 04.05.26 um 7:46 AM schrieb Arthur Bied-Charreton:
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index ef9555e6..6c9437b7 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -70,7 +70,11 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>  
>          let flags = '';
>  
> -        store.getData().each(function (rec) {
> +        // Get the values directly from the data source. Using store.getData() here
> +        // would iterate over the filtered values, potentially overwriting flags that
> +        // are set but currently filtered out by the search bar.
> +        let source = store.getDataSource();
> +        source.each(function (rec) {

Don't we have to do the same for the other usage of store.getData() for
clearing the previous unknown flags?

---snip 8<---

> +        if (!me.restrictToVMFlags) {
> +            topToolbarItems.push('-', {
> +                xtype: 'textfield',
> +                emptyText: gettext('Search...'),

Nit: seems like we use 'Search' without the dots in other places.