Re: [PATCH pve-manager v4 17/17] RFC: ui: group custom CPU with resource mappings

[Fiona Ebner <f.ebner@proxmox.com>]

Am 30.04.26 um 6:02 PM schrieb Arthur Bied-Charreton:
> As suggested by Fiona on the list [0], create a
> "Guest Resources/Hardware" group with "Custom CPU models", "Directory
> Mappings", and "Resource Mappings" in the Datacenter menu.
> 
> [0]
> https://lore.proxmox.com/pve-devel/b9274cb9-0ae1-46aa-a4b5-e10251c1a948@proxmox.com/T/#u
> 
> Suggested-by: Fiona Ebner <f.ebner@proxmox.com>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>

With my single comment addressed:

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
>  www/manager6/dc/Config.js | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
> index ad830ba8..119aba18 100644
> --- a/www/manager6/dc/Config.js
> +++ b/www/manager6/dc/Config.js
> @@ -379,6 +379,21 @@ Ext.define('PVE.dc.Config', {
>              );
>          }
>  
> +        if (
> +            caps.mapping['Mapping.Audit'] ||
> +            caps.mapping['Mapping.Use'] ||
> +            caps.mapping['Mapping.Modify'] ||
> +            caps.dc['Sys.Audit']
> +        ) {
> +            me.items.push({
> +                xtype: 'pveGuestResourcesAndHardwareView',

That xtype does not exist

> +                title: gettext('Guest Resources/Hardware'),
> +                iconCls: 'fa fa-sitemap',
> +                itemId: 'guestresourcesandhardware',
> +                expandedOnInit: true,
> +            });
> +        }
> +
>          if (
>              caps.mapping['Mapping.Audit'] ||
>              caps.mapping['Mapping.Use'] ||