Re: [PATCH docs/manager/qemu-server v4 00/17] Add API and UI for custom CPU models

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Mon, May 11, 2026 at 12:42:02PM +0200, Fiona Ebner wrote:
> I found a pre-existing bug in query_supported_cpu_flags() that we should
> fix. Namely the following replacement is wrong in general:
> 
> >             foreach my $prop (keys %$props) {
> >                 next if $props->{$prop} ne '1';
> >                 # QEMU returns some flags multiple times, with '_', '.' or '-'
> >                 # (e.g. lahf_lm and lahf-lm; sse4.2, sse4-2 and sse4_2; ...).
> >                 # We only keep those with underscores, to match /proc/cpuinfo
> >                 $prop =~ s/\.|-/_/g;
> >                 $flags->{$prop} = 1;
> >             }
> 
> In particular, flags like 'virt-ssbd' or 'amd-ssbd' or 'amd-no-ssb' are
> not present multiple times, but only in their exact form. Because of the
> replacement, we only consider e.g. 'virt_ssbd' and then mistakenly
> detect the flags as not supported on any node.
> 
> Let's just make an explicit map of what is actually duplicate and not do
> such general replacement here.
Thanks for catching that, that is indeed incorrect. I will fix this in a
preparatory patch in v5