From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9F0DC1FF133 for ; Mon, 11 May 2026 16:01:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 368191BAFC; Mon, 11 May 2026 16:01:51 +0200 (CEST) Message-ID: <16ff735e-97a3-4edf-b0eb-05f1004b4383@proxmox.com> Date: Mon, 11 May 2026 16:01:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-manager v4 17/17] RFC: ui: group custom CPU with resource mappings To: Arthur Bied-Charreton , pve-devel@lists.proxmox.com References: <20260430160109.565536-1-a.bied-charreton@proxmox.com> <20260430160109.565536-18-a.bied-charreton@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260430160109.565536-18-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778507963195 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: CZSXOGIHXMCUMKBUCJC67IUAJ2HOGJKX X-Message-ID-Hash: CZSXOGIHXMCUMKBUCJC67IUAJ2HOGJKX X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 30.04.26 um 6:02 PM schrieb Arthur Bied-Charreton: > As suggested by Fiona on the list [0], create a > "Guest Resources/Hardware" group with "Custom CPU models", "Directory > Mappings", and "Resource Mappings" in the Datacenter menu. > > [0] > https://lore.proxmox.com/pve-devel/b9274cb9-0ae1-46aa-a4b5-e10251c1a948@proxmox.com/T/#u > > Suggested-by: Fiona Ebner > Signed-off-by: Arthur Bied-Charreton With my single comment addressed: Reviewed-by: Fiona Ebner > --- > www/manager6/dc/Config.js | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js > index ad830ba8..119aba18 100644 > --- a/www/manager6/dc/Config.js > +++ b/www/manager6/dc/Config.js > @@ -379,6 +379,21 @@ Ext.define('PVE.dc.Config', { > ); > } > > + if ( > + caps.mapping['Mapping.Audit'] || > + caps.mapping['Mapping.Use'] || > + caps.mapping['Mapping.Modify'] || > + caps.dc['Sys.Audit'] > + ) { > + me.items.push({ > + xtype: 'pveGuestResourcesAndHardwareView', That xtype does not exist > + title: gettext('Guest Resources/Hardware'), > + iconCls: 'fa fa-sitemap', > + itemId: 'guestresourcesandhardware', > + expandedOnInit: true, > + }); > + } > + > if ( > caps.mapping['Mapping.Audit'] || > caps.mapping['Mapping.Use'] ||