public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Kaiyang Wu <wukaiyang2003@gmail.com>, pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: Re: [PATCH qemu-server/docs/manager v3 0/3] add pvpanic device support
Date: Fri, 30 Oct 2026 15:06:41 +0100	[thread overview]
Message-ID: <c7e84ad5-56af-42aa-8576-2e11d1f1fce0@proxmox.com> (raw)
In-Reply-To: <20261009065813.109006-1-wukaiyang@loongfans.cn>

thanks for the updated series!

i answer on the individual patches for some details.

What would also be nice in the future would be a qmevent patch that
listens for the panic event and maybe send out a notification via the
notification stack (or at least log it to the syslog).

This can be done later though, so nothing needed for this series.

On 10/9/26 8:58 AM, Kaiyang Wu wrote:
> This patchset adds pvpanic device support to QEMU virtual machines to
> provide extra virtual machine status (guest-panicked) when virtual
> machines panic [0].
> 
> [0]: https://www.qemu.org/docs/master/specs/pvpanic.html
> 
> v1: https://lore.proxmox.com/pve-devel/20260827103529.393388-1-wukaiyang@loongfans.cn/
> v2: https://lore.proxmox.com/pve-devel/20260914092015.125780-1-wukaiyang@loongfans.cn/
> 
> Changes v1 -> v2:
> - Remove the pvpanic ISA device support to simplify the code
> - Move the pvpanic setting from Hardware to Options
> - Restart a HA-managed VM when it panics to restore the "started" state
> 
> Changes v2 -> v3:
> - Allow to set panic action. The HA stack automatically restarts a panicked VM
>    when the VM exits using the 'exit-failure' panic action
> 
> 
> qemu-server:
> 
> Kaiyang Wu (1):
>    qemuserver: add pvpanic device
> 
>   src/PVE/API2/Qemu.pm      |  1 +
>   src/PVE/QemuServer.pm     | 42 +++++++++++++++++++++++++++++++++++++++
>   src/PVE/QemuServer/PCI.pm |  1 +
>   3 files changed, 44 insertions(+)
> 
> 
> docs:
> 
> Kaiyang Wu (1):
>    qm: add document section for the pvpanic device
> 
>   qm.adoc | 38 ++++++++++++++++++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
> 
> 
> manager:
> 
> Kaiyang Wu (1):
>    ui: qemu: add pvpanic device support
> 
>   www/manager6/Makefile                |  1 +
>   www/manager6/Utils.js                | 18 +++++++++
>   www/manager6/form/PvpanicSelector.js | 56 ++++++++++++++++++++++++++++
>   www/manager6/qemu/Options.js         | 16 ++++++++
>   4 files changed, 91 insertions(+)
>   create mode 100644 www/manager6/form/PvpanicSelector.js
> 





      parent reply	other threads:[~2026-10-30 14:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09  6:58 [PATCH qemu-server/docs/manager v3 0/3] add pvpanic device support Kaiyang Wu
2026-10-09  6:58 ` [PATCH qemu-server v3 1/3] qemuserver: add pvpanic device Kaiyang Wu
2026-10-30 14:06   ` Dominik Csapak
2026-10-09  6:58 ` [PATCH docs v3 2/3] qm: add document section for the " Kaiyang Wu
2026-10-30 14:06   ` Dominik Csapak
2026-10-09  6:58 ` [PATCH manager v3 3/3] ui: qemu: add pvpanic device support Kaiyang Wu
2026-10-30 14:06   ` Dominik Csapak
2026-10-28  3:29 ` [PATCH qemu-server/docs/manager v3 0/3] " Kaiyang Wu
2026-10-30 14:06 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7e84ad5-56af-42aa-8576-2e11d1f1fce0@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=wukaiyang2003@gmail.com \
    --cc=wukaiyang@loongfans.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal