From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 3ACC11FF0B7 for ; Fri, 30 Oct 2026 15:06:51 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 53BB2215F8; Fri, 30 Oct 2026 15:06:48 +0100 (CET) Message-ID: Date: Fri, 30 Oct 2026 15:06:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH qemu-server/docs/manager v3 0/3] add pvpanic device support To: Kaiyang Wu , pve-devel@lists.proxmox.com References: <20261009065813.109006-1-wukaiyang@loongfans.cn> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20261009065813.109006-1-wukaiyang@loongfans.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793369202156 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.340 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: W3VEK3GUV2OCBVWH4S7643KM5CD7OUUK X-Message-ID-Hash: W3VEK3GUV2OCBVWH4S7643KM5CD7OUUK X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: thanks for the updated series! i answer on the individual patches for some details. What would also be nice in the future would be a qmevent patch that listens for the panic event and maybe send out a notification via the notification stack (or at least log it to the syslog). This can be done later though, so nothing needed for this series. On 10/9/26 8:58 AM, Kaiyang Wu wrote: > This patchset adds pvpanic device support to QEMU virtual machines to > provide extra virtual machine status (guest-panicked) when virtual > machines panic [0]. > > [0]: https://www.qemu.org/docs/master/specs/pvpanic.html > > v1: https://lore.proxmox.com/pve-devel/20260827103529.393388-1-wukaiyang@loongfans.cn/ > v2: https://lore.proxmox.com/pve-devel/20260914092015.125780-1-wukaiyang@loongfans.cn/ > > Changes v1 -> v2: > - Remove the pvpanic ISA device support to simplify the code > - Move the pvpanic setting from Hardware to Options > - Restart a HA-managed VM when it panics to restore the "started" state > > Changes v2 -> v3: > - Allow to set panic action. The HA stack automatically restarts a panicked VM > when the VM exits using the 'exit-failure' panic action > > > qemu-server: > > Kaiyang Wu (1): > qemuserver: add pvpanic device > > src/PVE/API2/Qemu.pm | 1 + > src/PVE/QemuServer.pm | 42 +++++++++++++++++++++++++++++++++++++++ > src/PVE/QemuServer/PCI.pm | 1 + > 3 files changed, 44 insertions(+) > > > docs: > > Kaiyang Wu (1): > qm: add document section for the pvpanic device > > qm.adoc | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > > manager: > > Kaiyang Wu (1): > ui: qemu: add pvpanic device support > > www/manager6/Makefile | 1 + > www/manager6/Utils.js | 18 +++++++++ > www/manager6/form/PvpanicSelector.js | 56 ++++++++++++++++++++++++++++ > www/manager6/qemu/Options.js | 16 ++++++++ > 4 files changed, 91 insertions(+) > create mode 100644 www/manager6/form/PvpanicSelector.js >