Re: [PATCH qemu-server v3 1/3] qemuserver: add pvpanic device

[Dominik Csapak <d.csapak@proxmox.com>]

one comment inline, rest LGTM

On 10/9/26 8:59 AM, Kaiyang Wu wrote:
> Add pvpanic PCI device to monitor guest system panics. Allow to specify
> the action to perform when the guest system panics.
> 
> Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
> ---
>   src/PVE/API2/Qemu.pm      |  1 +
>   src/PVE/QemuServer.pm     | 42 +++++++++++++++++++++++++++++++++++++++
>   src/PVE/QemuServer/PCI.pm |  1 +
>   3 files changed, 44 insertions(+)
> 
> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
> index 922c6599..fb5c2f05 100644
> --- a/src/PVE/API2/Qemu.pm
> +++ b/src/PVE/API2/Qemu.pm
> @@ -818,6 +818,7 @@ my $hwtypeoptions = {
>       'watchdog' => 1,
>       'audio0' => 1,
>       'rng0' => 1,
> +    'pvpanic' => 1,
>   };
>   
>   my $generaloptions = {
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index f199371d..8698fb11 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -141,6 +141,23 @@ sub nodename {
>       return $nodename_cache;
>   }
>   
> +my $pvpanic_fmt = {
> +    enabled => {
> +        default_key => 1,
> +        type => 'boolean',
> +        description => "Create a pvpanic device to monitor guest panics.",
> +        default => 0,
> +    },
> +    action => {
> +        type => 'string',
> +        enum => [qw(none pause shutdown exit-failure)],
> +        description =>
> +            "The action to perform if the guest panics.",
> +        optional => 1,

since this is optional, it should define its default for the
docs.

> +    },
> +};
> +PVE::JSONSchema::register_format('pve-qm-pvpanic', $pvpanic_fmt);
> +
>   my $watchdog_fmt = {
>       model => {
>           default_key => 1,
> @@ -739,6 +756,12 @@ EODESCR
>           optional => 1,
>           default => 1,
>       },
> +    pvpanic => {
> +        optional => 1,
> +        type => 'string',
> +        format => 'pve-qm-pvpanic',
> +        description => "Create a panic monitor device.",
> +    },
>   };
>   
>   my $cicustom_fmt = {
> @@ -1674,6 +1697,16 @@ sub print_smbios1 {
>   
>   PVE::JSONSchema::register_format('pve-qm-smbios1', $smbios1_fmt);
>   
> +sub parse_pvpanic {
> +    my ($value) = @_;
> +
> +    return if !$value;
> +
> +    my $res = eval { parse_property_string($pvpanic_fmt, $value) };
> +    warn $@ if $@;
> +    return $res;
> +}
> +
>   sub parse_watchdog {
>       my ($value) = @_;
>   
> @@ -3556,6 +3589,15 @@ sub config_to_command {
>           push @$devices, '-device', $ballooncmd;
>       }
>   
> +    if ($conf->{pvpanic}) {
> +        my $pvpanicopts = parse_pvpanic($conf->{pvpanic});
> +        if ($pvpanicopts->{enabled}) {
> +            my $pvpanicpciaddr = print_pci_addr("pvpanic", $arch);
> +            push @$devices, '-device', "pvpanic-pci,id=pvpanic$pvpanicpciaddr";
> +        }
> +        push @$devices, '-action', "panic=$pvpanicopts->{action}" if $pvpanicopts->{action};
> +    }
> +
>       if ($conf->{watchdog}) {
>           my $wdopts = parse_watchdog($conf->{watchdog});
>           my $pciaddr = print_pci_addr("watchdog", $arch);
> diff --git a/src/PVE/QemuServer/PCI.pm b/src/PVE/QemuServer/PCI.pm
> index d7dc6121..5b0603a0 100644
> --- a/src/PVE/QemuServer/PCI.pm
> +++ b/src/PVE/QemuServer/PCI.pm
> @@ -220,6 +220,7 @@ sub get_pci_addr_map {
>           'pci.4' => { bus => 1, addr => 28 },
>           'rng0' => { bus => 1, addr => 29 },
>           'pci.2-igd' => { bus => 1, addr => 30 }, # replaces pci.2 in case a legacy IGD device is passed through
> +        'pvpanic' => { bus => 1, addr => 31 },
>           'virtio6' => { bus => 2, addr => 1 },
>           'virtio7' => { bus => 2, addr => 2 },
>           'virtio8' => { bus => 2, addr => 3 },