Re: [PATCH manager v3 3/3] ui: qemu: add pvpanic device support

[Dominik Csapak <d.csapak@proxmox.com>]

comments inline

On 10/9/26 8:59 AM, Kaiyang Wu wrote:
> Add basic structure for adding a pvpanic PCI device, allowing to monitor
> guest system panics through the pvpanic device, and specify panic action
> to execute when guest system panics.
> 
> Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
> ---
>   www/manager6/Makefile                |  1 +
>   www/manager6/Utils.js                | 18 +++++++++
>   www/manager6/form/PvpanicSelector.js | 56 ++++++++++++++++++++++++++++
>   www/manager6/qemu/Options.js         | 16 ++++++++
>   4 files changed, 91 insertions(+)
>   create mode 100644 www/manager6/form/PvpanicSelector.js
> 
> diff --git a/www/manager6/Makefile b/www/manager6/Makefile
> index d2ea786b..d3c15c29 100644
> --- a/www/manager6/Makefile
> +++ b/www/manager6/Makefile
> @@ -65,6 +65,7 @@ JSSRC= 							\
>   	form/PoolSelector.js				\
>   	form/PreallocationSelector.js			\
>   	form/PrivilegesSelector.js			\
> +	form/PvpanicSelector.js			\
>   	form/QemuBiosSelector.js			\
>   	form/QemuMachineSelector.js			\
>   	form/RecordSearchField.js			\
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index 8b99371d..8263eea7 100644
> --- a/www/manager6/Utils.js
> +++ b/www/manager6/Utils.js
> @@ -557,6 +557,24 @@ Ext.define('PVE.Utils', {
>               }
>           },
>   
> +        render_pvpanic: function (value) {
> +            if (!value) {
> +                return Proxmox.Utils.defaultText + ' (' + Proxmox.Utils.disabledText + ')';
> +            }
> +
> +            let pvpanic = PVE.Parser.parsePropertyString(value, 'enabled');
> +
> +            if (!PVE.Parser.parseBoolean(pvpanic.enabled)) {
> +                return Proxmox.Utils.disabledText;
> +            }
> +
> +            if (pvpanic.action) {
> +                return Proxmox.Utils.enabledText + `, Panic Action: ${pvpanic.action}`;
> +            } else {
> +                return Proxmox.Utils.enabledText + ', Panic Action: ' + Proxmox.Utils.defaultText + ' (shutdown)';
> +            }
> +        },
> +
>           render_dc_ha_opts: function (value) {
>               if (!value) {
>                   return Proxmox.Utils.defaultText;
> diff --git a/www/manager6/form/PvpanicSelector.js b/www/manager6/form/PvpanicSelector.js
> new file mode 100644
> index 00000000..eda5795d
> --- /dev/null
> +++ b/www/manager6/form/PvpanicSelector.js
> @@ -0,0 +1,56 @@
> +Ext.define('PVE.form.PvpanicSelector', {
> +    extend: 'Proxmox.panel.InputPanel',
> +    alias: 'widget.pvePvpanicSelector',
> +
> +    viewModel: {},
> +
> +    items: [
> +        {
> +            xtype: 'proxmoxcheckbox',
> +            fieldLabel: gettext('Enable'),
> +            name: 'enabled',
> +            reference: 'enabled',
> +            uncheckedValue: 0,
> +        },
> +        {
> +            xtype: 'proxmoxKVComboBox',
> +            fieldLabel: gettext('Panic Action'),
> +            name: 'action',
> +            value: '__default__',
> +            comboItems: [
> +                ['__default__', Proxmox.Utils.defaultText + ' (shutdown)'],
> +                ['none', 'none'],
> +                ['pause', 'pause'],
> +                ['shutdown', 'shutdown'],
> +                ['exit-failure', 'exit-failure'],

would be nice to have a better text (with gettext here)
for example:

none: gettext('No action')
pause: gettext('Guest will be paused')
shutdown: gettext('Default Shutdown action')
exit-failure: gettext('Guest will be stopped')

don't take these suggestions too seriously they are just
examples i came up with on the spot, but having
translatable strings makes it easier for the user
to understand what will happen (not everybody will
read the docs ;) )

> +            ],
> +            bind: {
> +                disabled: '{!enabled.checked}',
> +            },
> +        },
> +    ],
> +
> +    onGetValues: function (values) {
> +        let ret = {};
> +
> +        if (values.enabled) {
> +            ret.enabled = 1;
> +        }
> +        if (values.action) {
> +            ret.enabled = values.enabled;
> +            ret.action = values.action;
> +        }
> +        if (Ext.Object.isEmpty(ret)) {
> +            return { delete: 'pvpanic' };
> +        }
> +        let pvpanic = PVE.Parser.printPropertyString(ret, 'enabled');
> +        return { pvpanic: pvpanic };
> +    },
> +
> +    setValues: function (values) {
> +        if (values.pvpanic) {
> +            let pvpanic = PVE.Parser.parsePropertyString(values.pvpanic, 'enabled');
> +            this.callParent([pvpanic]);
> +        }
> +    },
> +});
> diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
> index 8a4721a0..75cdebf9 100644
> --- a/www/manager6/qemu/Options.js
> +++ b/www/manager6/qemu/Options.js
> @@ -311,6 +311,22 @@ Ext.define('PVE.qemu.Options', {
>                         }
>                       : undefined,
>               },
> +            pvpanic: {
> +                header: gettext('Panic Monitor'),
> +                defaultValue: false,
> +                renderer: PVE.Utils.render_pvpanic,
> +                editor: caps.vms['VM.Config.HWType']
> +                    ? {
> +                          xtype: 'proxmoxWindowEdit',
> +                          subject: gettext('Panic Monitor'),
> +                          onlineHelp: 'qm_pvpanic',
> +                          items: {
> +                              xtype: 'pvePvpanicSelector',
> +                              name: 'pvpanic',
> +                          },
> +                      }
> +                    : undefined,
> +            },
>               protection: {
>                   header: gettext('Protection'),
>                   defaultValue: false,