Re: [PATCH storage v7 2/4] fix #7339: lvm: add discard action for removed volumes

[Fiona Ebner <f.ebner@proxmox.com>]

Am 30.06.26 um 2:15 PM schrieb Fiona Ebner:
> Am 16.06.26 um 12:13 PM schrieb Lukas Sichert:
>> @@ -373,6 +381,14 @@ my sub free_lvm_volumes_locked {
>>                          die "short syswrite: wrote $written of $stepsize bytes\n";
>>                      }
>>                  }
>> +                if ($on_remove_opts->{discard}) {
>> +                    eval {
>> +                        blockdev_ioctl_range($fh, 'BLKDISCARD', BLKDISCARD, $offset, $stepsize);
>> +                    };
>> +                    if ($@) {
>> +                        log_warn("blkdiscard failed: $@");
> 
> Similar to the last patch, I would log the offset and length for
> completeness. I also wonder if we should

Oh, and I wonder if we should really log it for every failure
independently. Maybe just the first one and then count and log how many
operations failed in total? Depending on the scenario, it might be a
huge number of messages.

Together with checking for actual support first like Michael suggested.