From: Fiona Ebner <f.ebner@proxmox.com>
To: Lukas Sichert <l.sichert@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH docs v7 4/4] fix #7339: lvm: document discard option
Date: Tue, 30 Jun 2026 14:50:28 +0200 [thread overview]
Message-ID: <8f78d025-6cd5-44f1-934e-b21b740cdd5b@proxmox.com> (raw)
In-Reply-To: <20260616101323.24981-5-l.sichert@proxmox.com>
Am 16.06.26 um 12:13 PM schrieb Lukas Sichert:
> `saferemove_throughput`::
>
> -Wipe throughput (`cstream -t` parameter value), up to 10 MiB/s by default.
> +Wipe throughput, unlimited by default.
As mentioned in patch 1, we should keep the default for the syswrite
case. We can mention that if the more efficient zeroing operation is
supported, then the default throughput is unlimited.
And as discussed off-list: currently we do not look at the throughput at
all when BLKZEROOUT is supported. People might be surprised if they have
a (left-over) throughput limit configured which suddenly gets applied
after we roll out this series. But it can also be considered a bug that
it wasn't applied. What we should do is adding a log message that the
limit gets applied so that people notice. And adding a recommendation to
the docs that if BLKZEROOUT is supported, then removing the limit is
recommended (and how to check for support).
>
> `snapshot-as-volume-chain`::
>
prev parent reply other threads:[~2026-06-30 12:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 10:13 [PATCH docs/manager/storage v7 0/4] fix #7339: lvmthick: add option to free storage for deleted VMs Lukas Sichert
2026-06-16 10:13 ` [PATCH storage v7 1/4] lvm: saferemove: zero out volumes range by range Lukas Sichert
2026-06-30 11:49 ` Fiona Ebner
2026-06-30 14:16 ` Lukas Sichert
2026-06-30 14:28 ` Fiona Ebner
2026-06-16 10:13 ` [PATCH storage v7 2/4] fix #7339: lvm: add discard action for removed volumes Lukas Sichert
2026-06-30 10:55 ` Michael Köppl
2026-06-30 12:14 ` Fiona Ebner
2026-06-30 12:20 ` Fiona Ebner
2026-06-30 12:37 ` Fiona Ebner
2026-06-16 10:13 ` [PATCH manager v7 3/4] fix #7339: lvmthick: ui: add UI option to free storage Lukas Sichert
2026-06-30 11:38 ` Michael Köppl
2026-06-16 10:13 ` [PATCH docs v7 4/4] fix #7339: lvm: document discard option Lukas Sichert
2026-06-30 11:48 ` Michael Köppl
2026-06-30 12:50 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f78d025-6cd5-44f1-934e-b21b740cdd5b@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox