public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Lukas Sichert" <l.sichert@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH docs v7 4/4] fix #7339: lvm: document discard option
Date: Tue, 30 Jun 2026 13:48:50 +0200	[thread overview]
Message-ID: <DJMCZP4K5W96.27UAIS9GR9GFH@proxmox.com> (raw)
In-Reply-To: <20260616101323.24981-5-l.sichert@proxmox.com>

Added 1 suggestion inline. Other than that, consider this:

Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>

On Tue Jun 16, 2026 at 12:13 PM CEST, Lukas Sichert wrote:

[snip]

> +
> +`on-volume-remove`::
> +
> +Configure additional actions to run before removing an LV.
> ++
> +The initial supported option is `discard=1`. This issues discard requests for

IMO the way this is phrased reads a bit "roadmappy". Yes, there might be
more options to come, but I think something like this would work better:

"Configure additional actions to run before an LV is removed. Set
`discard=1` to issue a discard (TRIM) request for the LV's blocks before
the LV is remove, so thin-provisioned backing storage, such as a SAN
LUN, can reclaim space the LV occupied."

Just a suggestion, though.

> +the removed LV so thin-provisioned backing storage, for example a SAN LUN, can
> +reclaim the space used by the LV.
> ++
> +If `saferemove` is enabled too, the LV is processed range by range: one range is

[snip]




  reply	other threads:[~2026-06-30 11:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16 10:13 [PATCH docs/manager/storage v7 0/4] fix #7339: lvmthick: add option to free storage for deleted VMs Lukas Sichert
2026-06-16 10:13 ` [PATCH storage v7 1/4] lvm: saferemove: zero out volumes range by range Lukas Sichert
2026-06-30 11:49   ` Fiona Ebner
2026-06-30 14:16     ` Lukas Sichert
2026-06-30 14:28       ` Fiona Ebner
2026-06-16 10:13 ` [PATCH storage v7 2/4] fix #7339: lvm: add discard action for removed volumes Lukas Sichert
2026-06-30 10:55   ` Michael Köppl
2026-06-30 12:14   ` Fiona Ebner
2026-06-30 12:20     ` Fiona Ebner
2026-06-30 12:37     ` Fiona Ebner
2026-06-16 10:13 ` [PATCH manager v7 3/4] fix #7339: lvmthick: ui: add UI option to free storage Lukas Sichert
2026-06-30 11:38   ` Michael Köppl
2026-06-16 10:13 ` [PATCH docs v7 4/4] fix #7339: lvm: document discard option Lukas Sichert
2026-06-30 11:48   ` Michael Köppl [this message]
2026-06-30 12:50   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJMCZP4K5W96.27UAIS9GR9GFH@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal