* [PATCH manager] ui: fabrics: fix typo in translatable string
@ 2026-06-08 8:30 Maximiliano Sandoval
2026-06-08 9:55 ` Gabriel Goller
2026-06-08 15:27 ` Fiona Ebner
0 siblings, 2 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2026-06-08 8:30 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
www/manager6/sdn/fabrics/ospf/InterfacePanel.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
index 3a47bd524..f01625c49 100644
--- a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
@@ -10,7 +10,7 @@ Ext.define('PVE.sdn.Fabric.Ospf.NetworkTypeSelector', {
listConfig: {
columns: [
{
- header: gettext('NetworkType'),
+ header: gettext('Network Type'),
dataIndex: 'name',
hideable: false,
sortable: true,
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH manager] ui: fabrics: fix typo in translatable string
2026-06-08 8:30 [PATCH manager] ui: fabrics: fix typo in translatable string Maximiliano Sandoval
@ 2026-06-08 9:55 ` Gabriel Goller
2026-06-08 15:27 ` Fiona Ebner
1 sibling, 0 replies; 3+ messages in thread
From: Gabriel Goller @ 2026-06-08 9:55 UTC (permalink / raw)
To: Maximiliano Sandoval; +Cc: pve-devel
Consider:
Acked-by: Gabriel Goller <g.goller@proxmox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH manager] ui: fabrics: fix typo in translatable string
2026-06-08 8:30 [PATCH manager] ui: fabrics: fix typo in translatable string Maximiliano Sandoval
2026-06-08 9:55 ` Gabriel Goller
@ 2026-06-08 15:27 ` Fiona Ebner
1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2026-06-08 15:27 UTC (permalink / raw)
To: Maximiliano Sandoval, pve-devel
Am 08.06.26 um 10:30 AM schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> www/manager6/sdn/fabrics/ospf/InterfacePanel.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
> index 3a47bd524..f01625c49 100644
> --- a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
> +++ b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
> @@ -10,7 +10,7 @@ Ext.define('PVE.sdn.Fabric.Ospf.NetworkTypeSelector', {
> listConfig: {
> columns: [
> {
> - header: gettext('NetworkType'),
> + header: gettext('Network Type'),
> dataIndex: 'name',
> hideable: false,
> sortable: true,
Pre-existing, but should we rather just drop the header and make it a
combobox rather than a one-column combogrid? The header does look a bit
out of place IMHO.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-08 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-08 8:30 [PATCH manager] ui: fabrics: fix typo in translatable string Maximiliano Sandoval
2026-06-08 9:55 ` Gabriel Goller
2026-06-08 15:27 ` Fiona Ebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox