From: Fiona Ebner <f.ebner@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager] ui: fabrics: fix typo in translatable string
Date: Mon, 8 Jun 2026 17:27:24 +0200 [thread overview]
Message-ID: <0c960b31-7e98-490b-949f-d7cd0a914e15@proxmox.com> (raw)
In-Reply-To: <20260608083045.167772-1-m.sandoval@proxmox.com>
Am 08.06.26 um 10:30 AM schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> www/manager6/sdn/fabrics/ospf/InterfacePanel.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
> index 3a47bd524..f01625c49 100644
> --- a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
> +++ b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
> @@ -10,7 +10,7 @@ Ext.define('PVE.sdn.Fabric.Ospf.NetworkTypeSelector', {
> listConfig: {
> columns: [
> {
> - header: gettext('NetworkType'),
> + header: gettext('Network Type'),
> dataIndex: 'name',
> hideable: false,
> sortable: true,
Pre-existing, but should we rather just drop the header and make it a
combobox rather than a one-column combogrid? The header does look a bit
out of place IMHO.
prev parent reply other threads:[~2026-06-08 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 8:30 [PATCH manager] ui: fabrics: fix typo in translatable string Maximiliano Sandoval
2026-06-08 9:55 ` Gabriel Goller
2026-06-08 15:27 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c960b31-7e98-490b-949f-d7cd0a914e15@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox