From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 3B9171FF13B
	for <inbox@lore.proxmox.com>; Mon, 08 Jun 2026 17:27:30 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 84E3932BA5;
	Mon,  8 Jun 2026 17:27:28 +0200 (CEST)
Message-ID: <0c960b31-7e98-490b-949f-d7cd0a914e15@proxmox.com>
Date: Mon, 8 Jun 2026 17:27:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH manager] ui: fabrics: fix typo in translatable string
To: Maximiliano Sandoval <m.sandoval@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260608083045.167772-1-m.sandoval@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20260608083045.167772-1-m.sandoval@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1780932401108
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.009 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: UHGKLYFFI57OVCAON4RAERVQ2X2QMGHX
X-Message-ID-Hash: UHGKLYFFI57OVCAON4RAERVQ2X2QMGHX
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 08.06.26 um 10:30 AM schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  www/manager6/sdn/fabrics/ospf/InterfacePanel.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
> index 3a47bd524..f01625c49 100644
> --- a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
> +++ b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
> @@ -10,7 +10,7 @@ Ext.define('PVE.sdn.Fabric.Ospf.NetworkTypeSelector', {
>      listConfig: {
>          columns: [
>              {
> -                header: gettext('NetworkType'),
> +                header: gettext('Network Type'),
>                  dataIndex: 'name',
>                  hideable: false,
>                  sortable: true,

Pre-existing, but should we rather just drop the header and make it a
combobox rather than a one-column combogrid? The header does look a bit
out of place IMHO.