public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Thomas Ellmenreich <t.ellmenreich@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: Re: [PATCH common v2 1/2] fix #5978: pem parser: relax parsing of chain entries:
Date: Wed, 24 Jun 2026 11:27:27 +0200	[thread overview]
Message-ID: <b45020a7-31f4-4062-8cfe-6c5498108fa1@proxmox.com> (raw)
In-Reply-To: <20260617124251.89036-2-t.ellmenreich@proxmox.com>

Am 17.06.26 um 14:43 schrieb Thomas Ellmenreich:
> Relaxes the parser to allow for text and whitespaces inbetween certchain
> entries. The splitting of PEM chains was also reworked to split each entry at
> its end, grouping it with its leading text.
> 
> Added testsuite to cover a bunch of parsing edge cases.
> 
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
>  src/PVE/Certificate.pm |  25 +++-
>  test/Makefile          |   2 +
>  test/check_pem_test.pl | 332 +++++++++++++++++++++++++++++++++++++++++
>  test/split_pem_test.pl | 272 +++++++++++++++++++++++++++++++++
>  4 files changed, 625 insertions(+), 6 deletions(-)
>  create mode 100755 test/check_pem_test.pl
>  create mode 100755 test/split_pem_test.pl
> 
Noticed a few whitespace errors and formatting issues on applying.

Please ensure code is nicely formatted, for perl we use proxmox-perltidy, which
is a wrapper around upstream perltidy with a locked in configuration that matches
our style guide as closely as possible. Most repos provide a top level "tidy"
make target to simplify running this.




  reply	other threads:[~2026-06-24  9:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 12:42 [PATCH common/proxmox-acme v2 0/2] fix #5978: pem parser: relax parsing of chain entries Thomas Ellmenreich
2026-06-17 12:42 ` [PATCH common v2 1/2] fix #5978: pem parser: relax parsing of chain entries: Thomas Ellmenreich
2026-06-24  9:27   ` Thomas Lamprecht [this message]
2026-06-24 10:57   ` Fabian Grünbichler
2026-06-17 12:42 ` [PATCH proxmox-acme v2 2/2] " Thomas Ellmenreich
2026-06-24 10:57   ` Fabian Grünbichler
2026-06-24 11:38   ` Thomas Lamprecht
2026-06-17 13:21 ` [PATCH common/proxmox-acme v2 0/2] fix #5978: pem parser: relax parsing of chain entries Shannon Sterz
2026-06-18  8:46   ` Thomas Ellmenreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b45020a7-31f4-4062-8cfe-6c5498108fa1@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.ellmenreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal