From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3A7671FF13A for ; Wed, 24 Jun 2026 11:27:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E8BC113352; Wed, 24 Jun 2026 11:27:30 +0200 (CEST) Message-ID: Date: Wed, 24 Jun 2026 11:27:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH common v2 1/2] fix #5978: pem parser: relax parsing of chain entries: To: Thomas Ellmenreich , pve-devel@lists.proxmox.com References: <20260617124251.89036-1-t.ellmenreich@proxmox.com> <20260617124251.89036-2-t.ellmenreich@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260617124251.89036-2-t.ellmenreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782293235313 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DA3E7VUWTYS35I4VQY4UM2EWQIWOCQSU X-Message-ID-Hash: DA3E7VUWTYS35I4VQY4UM2EWQIWOCQSU X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 17.06.26 um 14:43 schrieb Thomas Ellmenreich: > Relaxes the parser to allow for text and whitespaces inbetween certchain > entries. The splitting of PEM chains was also reworked to split each entry at > its end, grouping it with its leading text. > > Added testsuite to cover a bunch of parsing edge cases. > > Signed-off-by: Thomas Ellmenreich > --- > src/PVE/Certificate.pm | 25 +++- > test/Makefile | 2 + > test/check_pem_test.pl | 332 +++++++++++++++++++++++++++++++++++++++++ > test/split_pem_test.pl | 272 +++++++++++++++++++++++++++++++++ > 4 files changed, 625 insertions(+), 6 deletions(-) > create mode 100755 test/check_pem_test.pl > create mode 100755 test/split_pem_test.pl > Noticed a few whitespace errors and formatting issues on applying. Please ensure code is nicely formatted, for perl we use proxmox-perltidy, which is a wrapper around upstream perltidy with a locked in configuration that matches our style guide as closely as possible. Most repos provide a top level "tidy" make target to simplify running this.