From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH common/proxmox-acme v2 0/2] fix #5978: pem parser: relax parsing of chain entries
Date: Thu, 18 Jun 2026 10:46:36 +0200 [thread overview]
Message-ID: <DJC1LN14UQR9.1BIXNSB20ON14@proxmox.com> (raw)
In-Reply-To: <DJBCTD75T5W9.1KV4I9BIXDCEY@proxmox.com>
Good point, thanks!
Changes since v1:
- Where in v1 check_pem was just a wrapper of split_pem, they now perform
different functions
- split_pem now purely splits the PEM chain into separate entries and does no
further validation. Returning each entry with its leading text.
- check_pem retains the original functionality, except when the multiple option
is active, in which case it uses split_pem to get single entries and then
calls itself recursively
- On the ACME side, errors are now captured, wrapped, and then rethrown.
prev parent reply other threads:[~2026-06-18 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 12:42 [PATCH common/proxmox-acme v2 0/2] fix #5978: pem parser: relax parsing of chain entries Thomas Ellmenreich
2026-06-17 12:42 ` [PATCH common v2 1/2] fix #5978: pem parser: relax parsing of chain entries: Thomas Ellmenreich
2026-06-17 12:42 ` [PATCH proxmox-acme v2 2/2] " Thomas Ellmenreich
2026-06-17 13:21 ` [PATCH common/proxmox-acme v2 0/2] fix #5978: pem parser: relax parsing of chain entries Shannon Sterz
2026-06-18 8:46 ` Thomas Ellmenreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJC1LN14UQR9.1BIXNSB20ON14@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox