Re: [PATCH common/proxmox-acme v2 0/2] fix #5978: pem parser: relax parsing of chain entries

["Shannon Sterz" <s.sterz@proxmox.com>]

On Wed Jun 17, 2026 at 2:42 PM CEST, Thomas Ellmenreich wrote:
> According to RFC 8555, expected certchains should come
> without whitespace or explanatory texts inbetween chain
> entries. These two patches relax our parser to also
> accept text or whitespaces inbetween chain entries.

just a small note: usually when sending a v2 (or any version > 1) it's
encouraged to include a lit of changes since the last version. see for
example the cover letter of Lukas' recent series [1].

[1]: https://lore.proxmox.com/pdm-devel/20260615125823.193288-1-l.wagner@proxmox.com/T/#m6a7b03e2c9c612b69f49541deadda2f3bd412492

>
> pve-common:
>
> Thomas Ellmenreich (1):
>   fix #5978: pem parser: relax parsing of chain entries:
>
>  src/PVE/Certificate.pm |  25 +++-
>  test/Makefile          |   2 +
>  test/check_pem_test.pl | 332 +++++++++++++++++++++++++++++++++++++++++
>  test/split_pem_test.pl | 272 +++++++++++++++++++++++++++++++++
>  4 files changed, 625 insertions(+), 6 deletions(-)
>  create mode 100755 test/check_pem_test.pl
>  create mode 100755 test/split_pem_test.pl
>
>
> proxmox-acme:
>
> Thomas Ellmenreich (1):
>   fix #5978: pem parser: relax parsing of chain entries:
>
>  src/PVE/ACME.pm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
>
> Summary over all repositories:
>   5 files changed, 629 insertions(+), 10 deletions(-)