From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7041F1FF14F for ; Wed, 17 Jun 2026 15:21:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 13F603614D; Wed, 17 Jun 2026 15:21:20 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 17 Jun 2026 15:21:14 +0200 Message-Id: To: "Thomas Ellmenreich" , Subject: Re: [PATCH common/proxmox-acme v2 0/2] fix #5978: pem parser: relax parsing of chain entries X-Mailer: aerc 0.20.0 References: <20260617124251.89036-1-t.ellmenreich@proxmox.com> In-Reply-To: <20260617124251.89036-1-t.ellmenreich@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781702417822 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.107 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7ESS7ZGWFY6ZUY4LFL67BTHZV4IAYXZC X-Message-ID-Hash: 7ESS7ZGWFY6ZUY4LFL67BTHZV4IAYXZC X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Jun 17, 2026 at 2:42 PM CEST, Thomas Ellmenreich wrote: > According to RFC 8555, expected certchains should come > without whitespace or explanatory texts inbetween chain > entries. These two patches relax our parser to also > accept text or whitespaces inbetween chain entries. just a small note: usually when sending a v2 (or any version > 1) it's encouraged to include a lit of changes since the last version. see for example the cover letter of Lukas' recent series [1]. [1]: https://lore.proxmox.com/pdm-devel/20260615125823.193288-1-l.wagner@pr= oxmox.com/T/#m6a7b03e2c9c612b69f49541deadda2f3bd412492 > > pve-common: > > Thomas Ellmenreich (1): > fix #5978: pem parser: relax parsing of chain entries: > > src/PVE/Certificate.pm | 25 +++- > test/Makefile | 2 + > test/check_pem_test.pl | 332 +++++++++++++++++++++++++++++++++++++++++ > test/split_pem_test.pl | 272 +++++++++++++++++++++++++++++++++ > 4 files changed, 625 insertions(+), 6 deletions(-) > create mode 100755 test/check_pem_test.pl > create mode 100755 test/split_pem_test.pl > > > proxmox-acme: > > Thomas Ellmenreich (1): > fix #5978: pem parser: relax parsing of chain entries: > > src/PVE/ACME.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > > Summary over all repositories: > 5 files changed, 629 insertions(+), 10 deletions(-)