From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 185401FF13F for ; Thu, 18 Jun 2026 10:47:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4DBB9EE28; Thu, 18 Jun 2026 10:47:10 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 18 Jun 2026 10:46:36 +0200 Message-Id: Subject: Re: [PATCH common/proxmox-acme v2 0/2] fix #5978: pem parser: relax parsing of chain entries From: "Thomas Ellmenreich" To: "Shannon Sterz" , X-Mailer: aerc 0.20.0 References: <20260617124251.89036-1-t.ellmenreich@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781772338883 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VY3ECXRJME3VOVUQ4QMNKNQHPDL5SC37 X-Message-ID-Hash: VY3ECXRJME3VOVUQ4QMNKNQHPDL5SC37 X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Good point, thanks! Changes since v1: - Where in v1 check_pem was just a wrapper of split_pem, they now perform different functions - split_pem now purely splits the PEM chain into separate entries and does = no=20 further validation. Returning each entry with its leading text. - check_pem retains the original functionality, except when the multiple op= tion is active, in which case it uses split_pem to get single entries and then= =20 calls itself recursively - On the ACME side, errors are now captured, wrapped, and then rethrown.