Re: [PATCH qemu-server v9 07/10] adapt linked clone check to not die if an error occurs during check

[Fiona Ebner <f.ebner@proxmox.com>]

A prefix for the commit title like "destroy vm:" would be nice. Same
goes for patch 6/10 where I only noticed it now.

Am 29.06.26 um 4:05 PM schrieb Michael Köppl:
> Align error handling behavior when checking for linked clones with the
> rest of destroy_vm's error handling approach. In case an error occurred,
> a warning is printed and the execution continues, since:
> 
> 1. The same validation occurs later in the process
> 2. The VM removal will still be blocked if the volume has linked clones
> 
> Originally-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
>  [ MK: log_warn if check fails instead of ignoring
>        resolve style nits ]
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
>  src/PVE/QemuServer.pm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index cdf66e89..ed5bca0c 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -1838,8 +1838,10 @@ sub destroy_vm {
>                  my $volid = $drive->{file};
>                  return if !$volid || $volid =~ m|^/|;
>  
> -                die "base volume '$volid' is still in use by linked cloned\n"
> -                    if PVE::Storage::volume_is_base_and_used($storecfg, $volid);
> +                my $result = eval { PVE::Storage::volume_is_base_and_used($storecfg, $volid) };
> +                log_warn("failed to check if volume '$volid' is used by linked clones: $@")
> +                    if $@;

Same as for patch 6/10, a code comment would be nice here.

> +                die "base volume '$volid' is still in use by linked cloned\n" if $result;
>  
>              },
>          );