Re: [PATCH docs/gui-tests/manager/network/proxmox{-ve-rs,-perl-rs} v3 00/13] Add IS-IS protocol to fabrics

[Hannes Laimer <h.laimer@proxmox.com>]

Aside from these very tiny nits/questions, looks very good to me:
 - could we have the same `network_type`-nob here that we introduced for
   OSPF?
 - the warning in the UI could be warpped in a `gettext()`
 - could we put `isisd => 1` behind an IS-IS fabric presence check? i
   guess that could break setups that have it enabled manually though..


Consider this:

Tested-by: Hannes Laimer <h.laimer@proxmox.com>
Reviewed-by: Hannes Laimer <h.laimer@proxmox.com>

On 2026-08-28 13:32, Gabriel Goller wrote:
> As part of our effort to deprecate the existing controllers and transition
> toward a fabric-based architecture, we are introducing an IS-IS fabric. To
> centralize all routing protocols, we plan to consolidate them under the
> "Fabrics" sidebar menu. Additionally, we aim to generate all routing protocol
> configurations in a unified location using Rust.
> 
> Following the integration of OpenFabric and OSPF, the next logical step is to
> migrate the IS-IS controller to the fabrics framework.
> 
> This patch series adds an IS-IS Fabric option to the "Fabrics" menu while
> retaining the original IS-IS controller for backward compatibility. Since the
> two do not interfere, we will include a warning recommending the use of the new
> IS-IS Fabrics instead. The primary difference between the IS-IS Controller and
> the IS-IS Fabric is that the Fabric does not automatically redistribute
> connected routes into the Link State DB. This change is intentional, as we
> intend to implement a more advanced redistribution and route-map mechanism in
> the future, rather than relying on a simple checkbox. Users who need to
> redistribute connected routes with the new IS-IS Fabrics can do so by manually
> adding the appropriate FRR statement to the /etc/frr/frr.conf.local file.
> 
> Changelog:
> v2:
>     * rebase ontop of master
> v1: 
>     * rebase ontop of template series
> 
> 
> proxmox-ve-rs:
> 
> Gabriel Goller (5):
>   frr: add fabric properties to ISIS types and rename domain
>   ve-config: add IS-IS fabric config parsing and frr config generation
>   ve-config: add integration tests for IS-IS fabrics
>   ve-config: add IS-IS status deserialization types
>   frr: accept legacy ISIS domain field
> 
>  proxmox-frr-templates/templates/isisd.jinja   |  23 +-
>  proxmox-frr/src/de/isis.rs                    | 103 ++++++++
>  proxmox-frr/src/de/mod.rs                     |   1 +
>  proxmox-frr/src/ser/isis.rs                   |  28 ++-
>  proxmox-frr/src/ser/mod.rs                    |  11 +
>  proxmox-ve-config/src/sdn/fabric/frr.rs       | 224 +++++++++++++++++-
>  proxmox-ve-config/src/sdn/fabric/mod.rs       | 109 +++++++++
>  .../src/sdn/fabric/section_config/fabric.rs   |  22 ++
>  .../src/sdn/fabric/section_config/mod.rs      |  19 ++
>  .../src/sdn/fabric/section_config/node.rs     |  21 ++
>  .../fabric/section_config/protocol/isis.rs    | 159 +++++++++++++
>  .../sdn/fabric/section_config/protocol/mod.rs |   1 +
>  .../tests/fabric/cfg/isis_default/fabrics.cfg |  18 ++
>  .../fabric/cfg/isis_dualstack/fabrics.cfg     |  22 ++
>  .../fabric/cfg/isis_ipv6_only/fabrics.cfg     |  18 ++
>  proxmox-ve-config/tests/fabric/main.rs        |  63 +++++
>  .../snapshots/fabric__isis_default_pve.snap   |  36 +++
>  .../snapshots/fabric__isis_default_pve1.snap  |  35 +++
>  .../snapshots/fabric__isis_dualstack_pve.snap |  48 ++++
>  .../snapshots/fabric__isis_ipv6_only_pve.snap |  37 +++
>  20 files changed, 992 insertions(+), 6 deletions(-)
>  create mode 100644 proxmox-frr/src/de/isis.rs
>  create mode 100644 proxmox-ve-config/src/sdn/fabric/section_config/protocol/isis.rs
>  create mode 100644 proxmox-ve-config/tests/fabric/cfg/isis_default/fabrics.cfg
>  create mode 100644 proxmox-ve-config/tests/fabric/cfg/isis_dualstack/fabrics.cfg
>  create mode 100644 proxmox-ve-config/tests/fabric/cfg/isis_ipv6_only/fabrics.cfg
>  create mode 100644 proxmox-ve-config/tests/fabric/snapshots/fabric__isis_default_pve.snap
>  create mode 100644 proxmox-ve-config/tests/fabric/snapshots/fabric__isis_default_pve1.snap
>  create mode 100644 proxmox-ve-config/tests/fabric/snapshots/fabric__isis_dualstack_pve.snap
>  create mode 100644 proxmox-ve-config/tests/fabric/snapshots/fabric__isis_ipv6_only_pve.snap
> 
> 
> proxmox-perl-rs:
> 
> Gabriel Goller (2):
>   pve-rs: fabrics: add IS-IS protocol ifupdown config generation
>   sdn: add IS-IS fabric status reporting
> 
>  pve-rs/src/bindings/sdn/fabrics.rs | 136 +++++
>  pve-rs/src/sdn/status.rs           | 949 +++++++++++++++++++++++++++--
>  2 files changed, 1026 insertions(+), 59 deletions(-)
> 
> 
> pve-network:
> 
> Gabriel Goller (2):
>   fabrics: add IS-IS api types
>   sdn: controllers: rename isis domain to fabric_id
> 
>  src/PVE/Network/SDN/Controllers/IsisPlugin.pm |  2 +-
>  src/PVE/Network/SDN/Fabrics.pm                | 51 ++++++++++++++++---
>  src/PVE/Network/SDN/Frr.pm                    |  1 +
>  3 files changed, 45 insertions(+), 9 deletions(-)
> 
> 
> pve-manager:
> 
> Gabriel Goller (2):
>   fabrics: add IS-IS panels
>   sdn: add warning about IS-IS controller deprecation
> 
>  www/manager6/Makefile                         |  3 ++
>  www/manager6/sdn/FabricsView.js               | 12 +++++
>  www/manager6/sdn/controllers/IsisEdit.js      |  5 ++
>  www/manager6/sdn/fabrics/NodeEdit.js          |  1 +
>  www/manager6/sdn/fabrics/isis/FabricEdit.js   | 48 +++++++++++++++++++
>  .../sdn/fabrics/isis/InterfacePanel.js        | 21 ++++++++
>  www/manager6/sdn/fabrics/isis/NodeEdit.js     |  9 ++++
>  7 files changed, 99 insertions(+)
>  create mode 100644 www/manager6/sdn/fabrics/isis/FabricEdit.js
>  create mode 100644 www/manager6/sdn/fabrics/isis/InterfacePanel.js
>  create mode 100644 www/manager6/sdn/fabrics/isis/NodeEdit.js
> 
> 
> pve-docs:
> 
> Gabriel Goller (1):
>   sdn: add section about IS-IS fabric
> 
>  pvesdn.adoc | 111 +++++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 105 insertions(+), 6 deletions(-)
> 
> 
> pve-gui-tests:
> 
> Gabriel Goller (1):
>   fabrics: add screenshots for IS-IS fabric and nodes
> 
>  pve/fabrics-screenshots | 47 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> 
> Summary over all repositories:
>   34 files changed, 2314 insertions(+), 80 deletions(-)
> 
> -- 
> Generated by murpp 0.11.0
> 
> 
> 
>