public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-gui-tests v3 13/13] fabrics: add screenshots for IS-IS fabric and nodes
Date: Fri, 28 Aug 2026 13:32:52 +0200	[thread overview]
Message-ID: <20260828113255.176546-14-g.goller@proxmox.com> (raw)
In-Reply-To: <20260828113255.176546-1-g.goller@proxmox.com>

Add IS-IS fabric and node screenshots.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 pve/fabrics-screenshots | 47 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/pve/fabrics-screenshots b/pve/fabrics-screenshots
index 726a8d88a731..b028b339ef19 100755
--- a/pve/fabrics-screenshots
+++ b/pve/fabrics-screenshots
@@ -13,6 +13,7 @@ sub prepare_fabrics {
     my ($conn) = @_;
     eval {
         # might not exist, so ignore any errors
+        $conn->delete("/cluster/sdn/fabrics/fabric/test3");
         $conn->delete("/cluster/sdn/fabrics/fabric/test2");
         $conn->delete("/cluster/sdn/fabrics/fabric/test1");
     };
@@ -29,14 +30,25 @@ sub prepare_fabrics {
         ip_prefix => "198.51.100.0/24",
         protocol => "ospf",
     };
+    my $isis = {
+        id => "test3",
+        ip_prefix => "192.0.15.0/24",
+        hello_interval => "1",
+        protocol => "isis",
+    };
     $conn->post("/cluster/sdn/fabrics/fabric", $openfabric);
     $conn->post("/cluster/sdn/fabrics/fabric", $ospf);
+    $conn->post("/cluster/sdn/fabrics/fabric", $isis);
+
 }
 
 sub prepare_nodes {
     my ($conn) = @_;
     eval {
         # might not exist, so ignore any errors
+        $conn->delete("/cluster/sdn/fabrics/node/test3/pve0");
+        $conn->delete("/cluster/sdn/fabrics/node/test3/pve1");
+        $conn->delete("/cluster/sdn/fabrics/node/test3/pve2");
         $conn->delete("/cluster/sdn/fabrics/node/test2/pve0");
         $conn->delete("/cluster/sdn/fabrics/node/test2/pve1");
         $conn->delete("/cluster/sdn/fabrics/node/test2/pve2");
@@ -52,6 +64,8 @@ sub prepare_nodes {
         my $last_octet = $i + 1;
         my $ospf_iface = ($i * 2) + 19;
         my $openfabric_iface = ($i * 2) + 25;
+        my $isis_iface = ($i * 2) + 30;
+
         
         my $ospf_node = {
             node_id => $node_name,
@@ -71,9 +85,21 @@ sub prepare_nodes {
             ],
             protocol => "openfabric",
         };
+        my $isis_node = {
+            node_id => $node_name,
+            ip => "192.0.15.$last_octet",
+            interfaces => [
+                "name=ens$isis_iface",
+                "name=ens" . ($isis_iface + 1)
+            ],
+            protocol => "isis",
+        };
+
         
         $conn->post("/cluster/sdn/fabrics/node/test1/", $openfabric_node);
         $conn->post("/cluster/sdn/fabrics/node/test2/", $ospf_node);
+        $conn->post("/cluster/sdn/fabrics/node/test3/", $isis_node);
+
     }
 }
 
@@ -141,6 +167,18 @@ sub create_fabrics_ui_screenshots {
     $gui->element_screenshot("gui-datacenter-create-fabric-openfabric.png", $window);
     $gui->window_close($window);
 
+    $menu = $gui->find_button('Add Fabric', $panel)->click();
+    $gui->find_menu_item('IS-IS')->click();
+
+    $window = $gui->find_dialog("Create: IS-IS");
+    $gui->setValue($window, 'id', 'test3');
+    $gui->setValue($window, 'ip_prefix', '192.0.2.0/24');
+    $gui->setValue($window, 'hello_interval', '1');
+
+    $gui->element_screenshot("gui-datacenter-create-fabric-isis.png", $window);
+    $gui->window_close($window);
+
+
     $menu = $gui->find_button('Add Fabric', $panel)->click();
     $gui->find_menu_item('OSPF')->click();
 
@@ -174,6 +212,15 @@ sub create_fabrics_ui_screenshots {
     $gui->element_screenshot("gui-datacenter-create-node-ospf.png", $window);
     $gui->window_close($window);
 
+    open_add_node_panel($gui, "isis");
+    sleep_ms(500);
+
+    $window = $gui->find_dialog("Create: Node");
+    $gui->setValue($window, 'ip', '198.51.100.1');
+    select_interfaces($gui, "ens19", "ens20");
+    $gui->element_screenshot("gui-datacenter-create-node-isis.png", $window);
+    $gui->window_close($window);
+
     # get fabric overview
     prepare_nodes($conn);
     sleep_ms(250);
-- 
2.47.3





      parent reply	other threads:[~2026-08-28 11:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 11:32 [PATCH docs/gui-tests/manager/network/proxmox{-ve-rs,-perl-rs} v3 00/13] Add IS-IS protocol to fabrics Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 01/13] frr: add fabric properties to ISIS types and rename domain Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 02/13] ve-config: add IS-IS fabric config parsing and frr config generation Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 03/13] ve-config: add integration tests for IS-IS fabrics Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 04/13] ve-config: add IS-IS status deserialization types Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-ve-rs v3 05/13] frr: accept legacy ISIS domain field Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-perl-rs v3 06/13] pve-rs: fabrics: add IS-IS protocol ifupdown config generation Gabriel Goller
2026-08-28 11:32 ` [PATCH proxmox-perl-rs v3 07/13] sdn: add IS-IS fabric status reporting Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-network v3 08/13] fabrics: add IS-IS api types Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-network v3 09/13] sdn: controllers: rename isis domain to fabric_id Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-manager v3 10/13] fabrics: add IS-IS panels Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-manager v3 11/13] sdn: add warning about IS-IS controller deprecation Gabriel Goller
2026-08-28 11:32 ` [PATCH pve-docs v3 12/13] sdn: add section about IS-IS fabric Gabriel Goller
2026-08-28 11:32 ` Gabriel Goller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260828113255.176546-14-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal