* [PATCH manager] 8to9: adapt to changed signature of get_vm_machine()
@ 2026-01-29 13:26 Fiona Ebner
2026-09-23 9:05 ` Fiona Ebner
0 siblings, 1 reply; 4+ messages in thread
From: Fiona Ebner @ 2026-01-29 13:26 UTC (permalink / raw)
To: pve-devel
The signature change in qemu-server does not lead to any breakage,
because the function still looks at $conf->{arch}. Still, it should be
adapted.
Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Dependency bump for qemu-server needed!
PVE/CLI/pve8to9.pm | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 0c4b2343..662ee943 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -931,7 +931,7 @@ my sub check_qemu_machine_versions {
my $conf = PVE::QemuConfig->load_config($vmid);
# first, actually configured machine version
- my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf, undef, $conf->{arch});
+ my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf);
if (
PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest
&& !PVE::QemuServer::Machine::is_machine_version_at_least($machine_type, @baseline)
@@ -942,9 +942,7 @@ my sub check_qemu_machine_versions {
# second, if hibernated, running machine version
if ($conf->{vmstate}) {
my $machine_type = PVE::QemuServer::Machine::get_vm_machine(
- $conf,
- $conf->{runningmachine},
- $conf->{arch},
+ $conf, $conf->{runningmachine},
);
if (
PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest
@@ -964,7 +962,6 @@ my sub check_qemu_machine_versions {
my $machine_type = PVE::QemuServer::Machine::get_vm_machine(
$snap_conf,
$snap_conf->{runningmachine},
- $snap_conf->{arch},
);
if ( # no version means latest
PVE::QemuServer::Machine::extract_version($machine_type)
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH manager] 8to9: adapt to changed signature of get_vm_machine()
2026-01-29 13:26 [PATCH manager] 8to9: adapt to changed signature of get_vm_machine() Fiona Ebner
@ 2026-09-23 9:05 ` Fiona Ebner
2026-10-21 11:29 ` Fiona Ebner
0 siblings, 1 reply; 4+ messages in thread
From: Fiona Ebner @ 2026-09-23 9:05 UTC (permalink / raw)
To: pve-devel
Am 29.01.26 um 2:25 PM schrieb Fiona Ebner:
> The signature change in qemu-server does not lead to any breakage,
> because the function still looks at $conf->{arch}. Still, it should be
> adapted.
>
> Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Dependency bump for qemu-server needed!
Ping. Still applies and the bump is already covered now :)
>
> PVE/CLI/pve8to9.pm | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
> index 0c4b2343..662ee943 100644
> --- a/PVE/CLI/pve8to9.pm
> +++ b/PVE/CLI/pve8to9.pm
> @@ -931,7 +931,7 @@ my sub check_qemu_machine_versions {
> my $conf = PVE::QemuConfig->load_config($vmid);
>
> # first, actually configured machine version
> - my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf, undef, $conf->{arch});
> + my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf);
> if (
> PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest
> && !PVE::QemuServer::Machine::is_machine_version_at_least($machine_type, @baseline)
> @@ -942,9 +942,7 @@ my sub check_qemu_machine_versions {
> # second, if hibernated, running machine version
> if ($conf->{vmstate}) {
> my $machine_type = PVE::QemuServer::Machine::get_vm_machine(
> - $conf,
> - $conf->{runningmachine},
> - $conf->{arch},
> + $conf, $conf->{runningmachine},
> );
> if (
> PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest
> @@ -964,7 +962,6 @@ my sub check_qemu_machine_versions {
> my $machine_type = PVE::QemuServer::Machine::get_vm_machine(
> $snap_conf,
> $snap_conf->{runningmachine},
> - $snap_conf->{arch},
> );
> if ( # no version means latest
> PVE::QemuServer::Machine::extract_version($machine_type)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH manager] 8to9: adapt to changed signature of get_vm_machine()
2026-09-23 9:05 ` Fiona Ebner
@ 2026-10-21 11:29 ` Fiona Ebner
2026-10-21 12:15 ` applied: " Fiona Ebner
0 siblings, 1 reply; 4+ messages in thread
From: Fiona Ebner @ 2026-10-21 11:29 UTC (permalink / raw)
To: pve-devel
Am 23.09.26 um 11:06 AM schrieb Fiona Ebner:
> Am 29.01.26 um 2:25 PM schrieb Fiona Ebner:
>> The signature change in qemu-server does not lead to any breakage,
>> because the function still looks at $conf->{arch}. Still, it should be
>> adapted.
>>
>> Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Dependency bump for qemu-server needed!
>
> Ping. Still applies and the bump is already covered now :)
>
Ping. Could somebody give me a review here?
>>
>> PVE/CLI/pve8to9.pm | 7 ++-----
>> 1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
>> index 0c4b2343..662ee943 100644
>> --- a/PVE/CLI/pve8to9.pm
>> +++ b/PVE/CLI/pve8to9.pm
>> @@ -931,7 +931,7 @@ my sub check_qemu_machine_versions {
>> my $conf = PVE::QemuConfig->load_config($vmid);
>>
>> # first, actually configured machine version
>> - my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf, undef, $conf->{arch});
>> + my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf);
>> if (
>> PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest
>> && !PVE::QemuServer::Machine::is_machine_version_at_least($machine_type, @baseline)
>> @@ -942,9 +942,7 @@ my sub check_qemu_machine_versions {
>> # second, if hibernated, running machine version
>> if ($conf->{vmstate}) {
>> my $machine_type = PVE::QemuServer::Machine::get_vm_machine(
>> - $conf,
>> - $conf->{runningmachine},
>> - $conf->{arch},
>> + $conf, $conf->{runningmachine},
>> );
>> if (
>> PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest
>> @@ -964,7 +962,6 @@ my sub check_qemu_machine_versions {
>> my $machine_type = PVE::QemuServer::Machine::get_vm_machine(
>> $snap_conf,
>> $snap_conf->{runningmachine},
>> - $snap_conf->{arch},
>> );
>> if ( # no version means latest
>> PVE::QemuServer::Machine::extract_version($machine_type)
^ permalink raw reply [flat|nested] 4+ messages in thread* applied: [PATCH manager] 8to9: adapt to changed signature of get_vm_machine()
2026-10-21 11:29 ` Fiona Ebner
@ 2026-10-21 12:15 ` Fiona Ebner
0 siblings, 0 replies; 4+ messages in thread
From: Fiona Ebner @ 2026-10-21 12:15 UTC (permalink / raw)
To: pve-devel
Am 21.10.26 um 1:29 PM schrieb Fiona Ebner:
> Am 23.09.26 um 11:06 AM schrieb Fiona Ebner:
>> Am 29.01.26 um 2:25 PM schrieb Fiona Ebner:
>>> The signature change in qemu-server does not lead to any breakage,
>>> because the function still looks at $conf->{arch}. Still, it should be
>>> adapted.
>>>
>>> Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
>>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>>> ---
>>>
>>> Dependency bump for qemu-server needed!
>>
>> Ping. Still applies and the bump is already covered now :)
>>
>
> Ping. Could somebody give me a review here?
Ah sorry, this already got applied as:
08ae5827 ("8to9: adapt to changed signature of get_vm_machine()")
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-21 12:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-29 13:26 [PATCH manager] 8to9: adapt to changed signature of get_vm_machine() Fiona Ebner
2026-09-23 9:05 ` Fiona Ebner
2026-10-21 11:29 ` Fiona Ebner
2026-10-21 12:15 ` applied: " Fiona Ebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox