From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id CABA01FF0C0 for ; Wed, 21 Oct 2026 13:29:06 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4348A215B0; Wed, 21 Oct 2026 13:29:05 +0200 (CEST) Message-ID: Date: Wed, 21 Oct 2026 13:29:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH manager] 8to9: adapt to changed signature of get_vm_machine() From: Fiona Ebner To: pve-devel@lists.proxmox.com References: <20260129132623.127384-1-f.ebner@proxmox.com> <4680ba6c-fd9e-47b3-b3b7-cc4ee97fca14@proxmox.com> Content-Language: en-US In-Reply-To: <4680ba6c-fd9e-47b3-b3b7-cc4ee97fca14@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792582141320 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.347 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JNHHGSWBFUEOPVE65C6BIPF72KLZAGPP X-Message-ID-Hash: JNHHGSWBFUEOPVE65C6BIPF72KLZAGPP X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 23.09.26 um 11:06 AM schrieb Fiona Ebner: > Am 29.01.26 um 2:25 PM schrieb Fiona Ebner: >> The signature change in qemu-server does not lead to any breakage, >> because the function still looks at $conf->{arch}. Still, it should be >> adapted. >> >> Reported-by: Thomas Lamprecht >> Signed-off-by: Fiona Ebner >> --- >> >> Dependency bump for qemu-server needed! > > Ping. Still applies and the bump is already covered now :) > Ping. Could somebody give me a review here? >> >> PVE/CLI/pve8to9.pm | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm >> index 0c4b2343..662ee943 100644 >> --- a/PVE/CLI/pve8to9.pm >> +++ b/PVE/CLI/pve8to9.pm >> @@ -931,7 +931,7 @@ my sub check_qemu_machine_versions { >> my $conf = PVE::QemuConfig->load_config($vmid); >> >> # first, actually configured machine version >> - my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf, undef, $conf->{arch}); >> + my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf); >> if ( >> PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest >> && !PVE::QemuServer::Machine::is_machine_version_at_least($machine_type, @baseline) >> @@ -942,9 +942,7 @@ my sub check_qemu_machine_versions { >> # second, if hibernated, running machine version >> if ($conf->{vmstate}) { >> my $machine_type = PVE::QemuServer::Machine::get_vm_machine( >> - $conf, >> - $conf->{runningmachine}, >> - $conf->{arch}, >> + $conf, $conf->{runningmachine}, >> ); >> if ( >> PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest >> @@ -964,7 +962,6 @@ my sub check_qemu_machine_versions { >> my $machine_type = PVE::QemuServer::Machine::get_vm_machine( >> $snap_conf, >> $snap_conf->{runningmachine}, >> - $snap_conf->{arch}, >> ); >> if ( # no version means latest >> PVE::QemuServer::Machine::extract_version($machine_type)