From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 09B581FF13F for ; Thu, 29 Jan 2026 14:26:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 893FE41D0; Thu, 29 Jan 2026 14:26:32 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH manager] 8to9: adapt to changed signature of get_vm_machine() Date: Thu, 29 Jan 2026 14:26:11 +0100 Message-ID: <20260129132623.127384-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769693119013 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EYQAV7VFGAFKIKLILGLYBOAGX2YILTM3 X-Message-ID-Hash: EYQAV7VFGAFKIKLILGLYBOAGX2YILTM3 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The signature change in qemu-server does not lead to any breakage, because the function still looks at $conf->{arch}. Still, it should be adapted. Reported-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- Dependency bump for qemu-server needed! PVE/CLI/pve8to9.pm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm index 0c4b2343..662ee943 100644 --- a/PVE/CLI/pve8to9.pm +++ b/PVE/CLI/pve8to9.pm @@ -931,7 +931,7 @@ my sub check_qemu_machine_versions { my $conf = PVE::QemuConfig->load_config($vmid); # first, actually configured machine version - my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf, undef, $conf->{arch}); + my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf); if ( PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest && !PVE::QemuServer::Machine::is_machine_version_at_least($machine_type, @baseline) @@ -942,9 +942,7 @@ my sub check_qemu_machine_versions { # second, if hibernated, running machine version if ($conf->{vmstate}) { my $machine_type = PVE::QemuServer::Machine::get_vm_machine( - $conf, - $conf->{runningmachine}, - $conf->{arch}, + $conf, $conf->{runningmachine}, ); if ( PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest @@ -964,7 +962,6 @@ my sub check_qemu_machine_versions { my $machine_type = PVE::QemuServer::Machine::get_vm_machine( $snap_conf, $snap_conf->{runningmachine}, - $snap_conf->{arch}, ); if ( # no version means latest PVE::QemuServer::Machine::extract_version($machine_type) -- 2.47.3