public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Raphael-Gauthier Flores <raphael.flores@inrae.fr>
To: Dominik Csapak <d.csapak@proxmox.com>,
	"pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: RE: applied: [PATCH] fix #8292: ui: node: StatusView: do not mutate the class-level items array
Date: Fri, 13 Nov 2026 08:00:12 +0000	[thread overview]
Message-ID: <a9c7aa8970c44402b0215caf80cae105@inrae.fr> (raw)
In-Reply-To: <0bb79287-708e-4d92-b275-876e1803bb8d@proxmox.com>

Hi Dominik,

Thank you for the validation and for the tips, I was not aware about this approach.

I'll take a look at git send-mail for configuring it properly.

Best,
Raphaël.

--
Raphaël FLORES, INRAE URGI / UR1164, RD10, 78026 Versailles Cedex - France
URGI platform IT manager  / BioinfOmics Research Infrastructure
Forge INRAE project lead / Research engineer
 ** Kindly hosted by ** / CNRGV @INRAE Toulouse
Note: I don't work on Fridays of odd-numbered weeks

________________________________________
De : Dominik Csapak <d.csapak@proxmox.com>
Envoyé : mercredi 11 novembre 2026 09h44
À : Raphael-Gauthier Flores; pve-devel@lists.proxmox.com
Objet : applied: [PATCH] fix #8292: ui: node: StatusView: do not mutate the class-level items array

applied, thanks!

Note that it seems your mail client mangled the mail and there were some
whitespace issues. I fixed that locally but please use
`git send-email` the next time, this would prevent such issues.

also, if sending a new version of the patch (even if it's just a resend)
you should begin a new thread, not answering on the same patch again

best regards
Dominik

On 11/10/26 3:36 PM, Raphaël Flores wrote:
>  From 6c7af488e31e006d500353134f21028e13345005 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Rapha=C3=ABl=20Flores?= <raphael.flores@inrae.fr>
> Date: Tue, 10 Nov 2026 15:24:47 +0100
> Subject: [PATCH] fix #8292: ui: node: StatusView: do not mutate the
>   class-level items array
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The repository status widget is appended to `items` in
> initComponent, but `items` is declared at class level, so every
> instance of PVE.node.StatusView receives the very same array. Each
> instantiation therefore left one more config object in that shared
> array: the k-th display of a node's Summary page constructed k
> pmxNodeInfoRepoStatus widgets instead of one, and all but one of
> them were never destroyed (they stay registered in
> Ext.ComponentManager, with no DOM node, and are not freed by the
> cycle collector).
>
> The node view is rebuilt on every display of the summary panel, so
> the waste grows quadratically with navigation: 322 displays left
> 52 004 live widget instances and 208 322 ExtJS components behind,
> while the DOM stayed flat.
>
> Build a per-instance array instead of pushing onto the shared one.
>
> Signed-off-by: Raphaël Flores <raphael.flores@inrae.fr>
> ---
>   www/manager6/node/StatusView.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/
> StatusView.js
> index 0046f5d5..08d68a95 100644
> --- a/www/manager6/node/StatusView.js
> +++ b/www/manager6/node/StatusView.js
> @@ -157,7 +157,7 @@ Ext.define('PVE.node.StatusView', {
>               nodetab: 'aptrepositories',
>           });
>
> -        me.items.push({
> +        me.items = me.items.concat({
>               xtype: 'pmxNodeInfoRepoStatus',
>               itemId: 'repositoryStatus',
>               product: 'Proxmox VE',









      reply	other threads:[~2026-11-13  8:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 16:08 [PATCH] fix #8292: ui: node: StatusView: do not mutate the class-level items array Raphaël Flores
2026-11-05 12:26 ` Dominik Csapak
2026-11-09 14:06   ` Raphaël Flores
2026-11-10 12:09     ` Dominik Csapak
2026-11-10 14:28       ` Raphaël Flores
2026-11-10 14:36         ` Raphaël Flores
2026-11-11  8:44           ` applied: " Dominik Csapak
2026-11-13  8:00             ` Raphael-Gauthier Flores [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9c7aa8970c44402b0215caf80cae105@inrae.fr \
    --to=raphael.flores@inrae.fr \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal