Re: [PATCH] fix #8292: ui: node: StatusView: do not mutate the class-level items array

[Dominik Csapak <d.csapak@proxmox.com>]

Hi,

thanks for your contribution

The patch itself looks good, but did you see
https://pve.proxmox.com/wiki/Developer_Documentation ?

especially the part about signing a CLA?

We'd need that before we apply patches of yours.

best regards
Dominik

On 11/5/26 12:44 PM, Raphaël Flores wrote:
> The repository status widget is appended to `items` in initComponent, but
> `items` is declared at class level, so every instance of 
> PVE.node.StatusView
> receives the very same array. Each instantiation therefore left one more
> config object in that shared array: the k-th display of a node's Summary 
> page
> constructed k pmxNodeInfoRepoStatus widgets instead of one, and all but 
> one of
> them were never destroyed (they stay registered in Ext.ComponentManager, 
> with
> no DOM node, and are not freed by the cycle collector).
> 
> The node view is rebuilt on every display of the summary panel, so the 
> waste
> grows quadratically with navigation: 322 displays left 52 004 live widget
> instances and 208 322 ExtJS components behind, while the DOM stayed flat.
> 
> Build a per-instance array instead of pushing onto the shared one.
> 
> Signed-off-by: Raphaël Flores <raphael.flores@inrae.fr>
> ---
>   www/manager6/node/StatusView.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/ 
> StatusView.js
> index 0046f5d5..08d68a95 100644
> --- a/www/manager6/node/StatusView.js
> +++ b/www/manager6/node/StatusView.js
> @@ -157,7 +157,7 @@ Ext.define('PVE.node.StatusView', {
>               nodetab: 'aptrepositories',
>           });
> 
> -        me.items.push({
> +        me.items = me.items.concat({
>               xtype: 'pmxNodeInfoRepoStatus',
>               itemId: 'repositoryStatus',
>               product: 'Proxmox VE',