From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id B48961FF0B7 for ; Fri, 13 Nov 2026 09:00:28 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4A75E217AC; Fri, 13 Nov 2026 09:00:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=s1024; d=inrae.fr; h=from:to:subject:date:message-id:in-reply-to:content-type:mime-version; bh=QfN9Atl+A0ydfRo7qa7N0MbQbDj9xFM9lJAy+6JzXkk=; b=LKyW4+IrZCq8knxeImIKkA0lnqNtjHbqKjPK/GQEfaWMpW2cV+AbuGyfLzpqum qQY0Uuj7g7D5K5LGSuLFb8X0srVQtBrNpxyG0/joK1hCtNTP5xSarHEin0KXA+ OE8MPElB6oet2qoJQc3wOOW+AcUpko6Qs/cxaDfYnnTOudA= From: Raphael-Gauthier Flores To: Dominik Csapak , "pve-devel@lists.proxmox.com" Subject: RE: applied: [PATCH] fix #8292: ui: node: StatusView: do not mutate the class-level items array Thread-Topic: applied: [PATCH] fix #8292: ui: node: StatusView: do not mutate the class-level items array Thread-Index: AQHdbHawcGJL18ixzEe+UY3LyjNGHrcfWDKAgAZ12wCAAWD5AIAAN7KAgAACEoCAAR8yAIADKI6u Date: Fri, 13 Nov 2026 08:00:12 +0000 Message-ID: References: <0c0f6a2b-b475-4f41-9342-c0d4ae94becc@inrae.fr> <9f4c7322-016f-4563-9365-023753718930@proxmox.com> <58d748c6-e255-4ce5-9249-4c8c080ce9c5@inrae.fr> <9bacc7c5-d0ba-45a4-9b81-8da9c3de22ff@proxmox.com> <61b3b992-0375-4cfc-989d-a9d0b08fefbe@inrae.fr> ,<0bb79287-708e-4d92-b275-876e1803bb8d@proxmox.com> In-Reply-To: <0bb79287-708e-4d92-b275-876e1803bb8d@proxmox.com> Accept-Language: fr-FR, en-US Content-Language: fr-FR X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [147.100.174.21] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LIJPI2PT7DWYMEFP3Y437R4PFT64NB3O X-Message-ID-Hash: LIJPI2PT7DWYMEFP3Y437R4PFT64NB3O X-MailFrom: raphael.flores@inrae.fr X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Dominik, Thank you for the validation and for the tips, I was not aware about this a= pproach. I'll take a look at git send-mail for configuring it properly. Best, Rapha=EBl. -- Rapha=EBl FLORES, INRAE URGI / UR1164, RD10, 78026 Versailles Cedex - Franc= e URGI platform IT manager / BioinfOmics Research Infrastructure Forge INRAE project lead / Research engineer ** Kindly hosted by ** / CNRGV @INRAE Toulouse Note: I don't work on Fridays of odd-numbered weeks ________________________________________ De : Dominik Csapak Envoy=E9 : mercredi 11 novembre 2026 09h44 =C0 : Raphael-Gauthier Flores; pve-devel@lists.proxmox.com Objet : applied: [PATCH] fix #8292: ui: node: StatusView: do not mutate the= class-level items array applied, thanks! Note that it seems your mail client mangled the mail and there were some whitespace issues. I fixed that locally but please use `git send-email` the next time, this would prevent such issues. also, if sending a new version of the patch (even if it's just a resend) you should begin a new thread, not answering on the same patch again best regards Dominik On 11/10/26 3:36 PM, Rapha=EBl Flores wrote: > From 6c7af488e31e006d500353134f21028e13345005 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Rapha=3DC3=3DABl=3D20Flores?=3D > Date: Tue, 10 Nov 2026 15:24:47 +0100 > Subject: [PATCH] fix #8292: ui: node: StatusView: do not mutate the > class-level items array > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > The repository status widget is appended to `items` in > initComponent, but `items` is declared at class level, so every > instance of PVE.node.StatusView receives the very same array. Each > instantiation therefore left one more config object in that shared > array: the k-th display of a node's Summary page constructed k > pmxNodeInfoRepoStatus widgets instead of one, and all but one of > them were never destroyed (they stay registered in > Ext.ComponentManager, with no DOM node, and are not freed by the > cycle collector). > > The node view is rebuilt on every display of the summary panel, so > the waste grows quadratically with navigation: 322 displays left > 52 004 live widget instances and 208 322 ExtJS components behind, > while the DOM stayed flat. > > Build a per-instance array instead of pushing onto the shared one. > > Signed-off-by: Rapha=EBl Flores > --- > www/manager6/node/StatusView.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/ > StatusView.js > index 0046f5d5..08d68a95 100644 > --- a/www/manager6/node/StatusView.js > +++ b/www/manager6/node/StatusView.js > @@ -157,7 +157,7 @@ Ext.define('PVE.node.StatusView', { > nodetab: 'aptrepositories', > }); > > - me.items.push({ > + me.items =3D me.items.concat({ > xtype: 'pmxNodeInfoRepoStatus', > itemId: 'repositoryStatus', > product: 'Proxmox VE',