Re: [PATCH] fix #8292: ui: node: StatusView: do not mutate the class-level items array

["Raphaël Flores" <raphael.flores@inrae.fr>]

[-- Attachment #1.1: Type: text/plain, Size: 1350 bytes --]

Hi Dominik,

Le 10/11/2026 à 13:09, Dominik Csapak a écrit :
>
>>
>> thanks for the quick review.
>>
>> I've read the Developer Documentation and have sent the signed
>> Contributor License Agreement to office@proxmox.com.
>
> thanks for confirmation. I did try to apply the patch,
> but `git am` wouldn't let me, probably because of the post diff
> message or footer.
>
> Normally comments go after the '---' after the commit
> message before the actual diff (i marked the part inline)
>
> would you mind sending the patch again with the comment
> (re)moved ?

Sure!

Here it is.

Thanks

Raphaël


Signed-off-by: Raphaël Flores <raphael.flores@inrae.fr>
---
  www/manager6/node/StatusView.js | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/node/StatusView.js 
b/www/manager6/node/StatusView.js
index 0046f5d5..08d68a95 100644
--- a/www/manager6/node/StatusView.js
+++ b/www/manager6/node/StatusView.js
@@ -157,7 +157,7 @@ Ext.define('PVE.node.StatusView', {
              nodetab: 'aptrepositories',
          });

-        me.items.push({
+        me.items = me.items.concat({
              xtype: 'pmxNodeInfoRepoStatus',
              itemId: 'repositoryStatus',
              product: 'Proxmox VE',
-- 
2.56.0


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]