Re: [PATCH proxmox v4 17/39] notify: matcher: don't allow empty field/severity matchers

["Lukas Wagner" <l.wagner@proxmox.com>]

On Wed Oct 21, 2026 at 4:39 PM CEST, Michael Köppl wrote:
> On Mon Oct 12, 2026 at 3:13 PM CEST, Lukas Wagner wrote:
>
> [snip]
>
>> +
>>  #[cfg(test)]
>>  mod test {
>>      use proxmox_match_expression::Expression;
>> diff --git a/proxmox-notify/src/matcher/field.rs b/proxmox-notify/src/matcher/field.rs
>> index 4a4b2588..cd23ff9c 100644
>> --- a/proxmox-notify/src/matcher/field.rs
>> +++ b/proxmox-notify/src/matcher/field.rs
>> @@ -53,6 +53,18 @@ impl MatchDirective for FieldMatcher {
>>              }
>>          })
>>      }
>> +
>> +    fn validate(&self) -> Result<(), Error> {
>
> This does allow empty field names, though. More generally, the old field
> matcher validated by making sure that the string matches SAFE_ID_REGEX.
> So compared to the legacy matchers, this would allow spaces, umlauts,
> line breaks, etc. as well.
>
> So perhaps matching against SAFE_ID_REGEX should be performed here
> again?

Seems sensible, nice catch!