From: Lukas Wagner <l.wagner@proxmox.com>
To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-perl-rs v4 26/39] notify: move proxmox-notify bindings from common to pve-rs
Date: Mon, 12 Oct 2026 15:14:00 +0200 [thread overview]
Message-ID: <20261012131413.314088-27-l.wagner@proxmox.com> (raw)
In-Reply-To: <20261012131413.314088-1-l.wagner@proxmox.com>
PMG neither uses the notification stack, nor is it planned in the near
future. Shipping the bindings in 'common' is awkward, since it then
requires us to use the same feature flags in proxmox-notify for both,
PVE and PMG.
This reduces the number of dependencies for pmg-rs from 297 to 269, all
of the removed ones were unused before.
The module prefix changes from Proxmox::RS::Notify to PVE::RS::Notify,
which is a breaking change that requires changes in the callers.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
common/pkg/Makefile | 1 -
common/src/bindings/mod.rs | 3 ---
pmg-rs/Cargo.toml | 1 -
pve-rs/Makefile | 1 +
pve-rs/src/bindings/mod.rs | 3 +++
{common => pve-rs}/src/bindings/notify.rs | 8 ++++----
6 files changed, 8 insertions(+), 9 deletions(-)
rename {common => pve-rs}/src/bindings/notify.rs (99%)
diff --git a/common/pkg/Makefile b/common/pkg/Makefile
index 5a537f9..1fce22f 100644
--- a/common/pkg/Makefile
+++ b/common/pkg/Makefile
@@ -23,7 +23,6 @@ PERLMOD_GENPACKAGE := /usr/lib/perlmod/genpackage.pl \
PERLMOD_PACKAGES := \
Proxmox::RS::APT::Repositories \
Proxmox::RS::CalendarEvent \
- Proxmox::RS::Notify \
Proxmox::RS::OIDC \
Proxmox::RS::SharedCache \
Proxmox::RS::Subscription
diff --git a/common/src/bindings/mod.rs b/common/src/bindings/mod.rs
index e0d1a3b..f122b9a 100644
--- a/common/src/bindings/mod.rs
+++ b/common/src/bindings/mod.rs
@@ -8,9 +8,6 @@ pub use apt_repositories::proxmox_rs_apt_repositories;
mod calendar_event;
pub use calendar_event::proxmox_rs_calendar_event;
-mod notify;
-pub use notify::proxmox_rs_notify;
-
mod oidc;
pub use oidc::proxmox_rs_oidc;
diff --git a/pmg-rs/Cargo.toml b/pmg-rs/Cargo.toml
index 23be254..f88a204 100644
--- a/pmg-rs/Cargo.toml
+++ b/pmg-rs/Cargo.toml
@@ -35,7 +35,6 @@ proxmox-config-digest = "1"
proxmox-http = { version = "1", features = ["client-sync", "client-trait"] }
proxmox-http-error = "1"
proxmox-log = "1"
-proxmox-notify = "1"
proxmox-openid = "1"
proxmox-shared-cache = "1"
proxmox-subscription = "1.0.2"
diff --git a/pve-rs/Makefile b/pve-rs/Makefile
index bb1cd2d..4c183c8 100644
--- a/pve-rs/Makefile
+++ b/pve-rs/Makefile
@@ -27,6 +27,7 @@ PERLMOD_GENPACKAGE := /usr/lib/perlmod/genpackage.pl \
PERLMOD_PACKAGES := \
PVE::RS::Firewall::SDN \
+ PVE::RS::Notify \
PVE::RS::NVML \
PVE::RS::OCI \
PVE::RS::OpenId \
diff --git a/pve-rs/src/bindings/mod.rs b/pve-rs/src/bindings/mod.rs
index f922982..143a62b 100644
--- a/pve-rs/src/bindings/mod.rs
+++ b/pve-rs/src/bindings/mod.rs
@@ -19,6 +19,9 @@ pub mod firewall;
mod sdn;
pub use sdn::fabrics::pve_rs_sdn_fabrics;
+mod notify;
+pub use notify::pve_rs_notify;
+
#[allow(unused_imports)]
pub use crate::common::bindings::*;
diff --git a/common/src/bindings/notify.rs b/pve-rs/src/bindings/notify.rs
similarity index 99%
rename from common/src/bindings/notify.rs
rename to pve-rs/src/bindings/notify.rs
index 409270a..ba713e3 100644
--- a/common/src/bindings/notify.rs
+++ b/pve-rs/src/bindings/notify.rs
@@ -1,6 +1,6 @@
-#[perlmod::package(name = "Proxmox::RS::Notify")]
-pub mod proxmox_rs_notify {
- //! The `Proxmox::RS::Notify` package.
+#[perlmod::package(name = "PVE::RS::Notify")]
+pub mod pve_rs_notify {
+ //! The `PVE::RS::Notify` package.
//!
//! This implements the new notification API and support code.
//!
@@ -45,7 +45,7 @@ pub mod proxmox_rs_notify {
config: Mutex<Config>,
}
- perlmod::declare_magic!(Box<NotificationConfig> : &NotificationConfig as "Proxmox::RS::Notify");
+ perlmod::declare_magic!(Box<NotificationConfig> : &NotificationConfig as "PVE::RS::Notify");
/// Method: Support `dclone` so this can be put into the `ccache` of `PVE::Cluster`.
#[export(name = "STORABLE_freeze", raw_return)]
--
2.47.3
next prev parent reply other threads:[~2026-10-12 13:19 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 13:13 [PATCH many v4 00/39] notifications: add nested match expressions Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 01/39] add new proxmox-match-expression crate Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 02/39] notify: log which matchers matched on a notification Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 03/39] notify: promote matcher to dir-style module Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 04/39] notify: fix doc comment Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 05/39] notify: matcher: break out severity matcher into submodule Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 06/39] notify: matcher: break out field " Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 07/39] notify: matcher: break out calendar " Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 08/39] notify: matcher: calendar: add basic unit test Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 09/39] notify: matcher: add InlineSeverityMatcher Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 10/39] notify: matcher: add InlineFieldMatcher Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 11/39] notify: matcher: add InlineCalendarMatcher Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 12/39] notify: matcher: add expression support Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 13/39] notify: api: support new expression parameter Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 14/39] notify: api: add `get_matcher_as_expression` Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 15/39] notify: migrate PBS's and PVE's default matcher to expression syntax Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 16/39] notify: move legacy matcher keys behind feature flag Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 17/39] notify: matcher: don't allow empty field/severity matchers Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox v4 18/39] notify: matcher: re-serialize expression on create/update Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox-widget-toolkit v4 19/39] notifications: increase matcher window width Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox-widget-toolkit v4 20/39] notifications: matcher: add support for match expressions Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox-widget-toolkit v4 21/39] notifications: matcher: add better calendar editor Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox-widget-toolkit v4 22/39] notifications: matcher: consistently use title case for UI elements Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox-backup v4 23/39] notification: opt into 'legacy-matchers' feature in proxmox-notify Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox-backup v4 24/39] api: notification: add 'migrate-to-expression' parameter to get_matcher Lukas Wagner
2026-10-12 13:13 ` [PATCH proxmox-backup v4 25/39] ui: notification: enable new matcher UI Lukas Wagner
2026-10-12 13:14 ` Lukas Wagner [this message]
2026-10-12 13:14 ` [PATCH proxmox-perl-rs v4 27/39] notify: matcher: pass matcher config / updater directly Lukas Wagner
2026-10-12 13:14 ` [PATCH proxmox-perl-rs v4 28/39] notify: opt into 'legacy-matchers' feature in proxmox-notify Lukas Wagner
2026-10-12 13:14 ` [PATCH proxmox-perl-rs v4 29/39] notify: add 'migrate_to_expression' parameter for get_matcher Lukas Wagner
2026-10-12 13:14 ` [PATCH pve-cluster v4 30/39] notify: adapt to changed module prefix for PVE::RS::Notify Lukas Wagner
2026-10-12 13:14 ` [PATCH pve-cluster v4 31/39] cluster: move pvecfg node version helpers from qemu-server Lukas Wagner
2026-10-12 13:14 ` [PATCH common v4 32/39] tools: move version_cmp() helper " Lukas Wagner
2026-10-12 13:14 ` [PATCH manager v4 33/39] vzdump: adapt to changed module prefix for PVE::RS::Notify Lukas Wagner
2026-10-12 13:14 ` [PATCH manager v4 34/39] api: notification: pass config/updater directly to rust bindings Lukas Wagner
2026-10-12 13:14 ` [PATCH manager v4 35/39] api: notification: get_matcher: add 'migrate-to-expression' parameter Lukas Wagner
2026-10-12 13:14 ` [PATCH manager v4 36/39] api: notification: add 'expression' to matcher parameter schema Lukas Wagner
2026-10-12 13:14 ` [PATCH manager v4 37/39] ui: notification: enable new matcher UI Lukas Wagner
2026-10-12 13:14 ` [PATCH manager v4 38/39] api: notification: reject matchers with expression if not supported by all nodes Lukas Wagner
2026-10-12 13:14 ` [PATCH proxmox-mail-forward v4 39/39] cargo: opt into legacy-matchers feature Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012131413.314088-27-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox