Re: [PATCH proxmox v4 15/39] notify: migrate PBS's and PVE's default matcher to expression syntax

["Michael Köppl" <m.koeppl@proxmox.com>]

On Mon Oct 12, 2026 at 3:13 PM CEST, Lukas Wagner wrote:

[snip]

> +            use proxmox_match_expression::{not, any_of, all_of};
> +
> +            let expression = any_of![
> +                not!(
> +                    FieldMatcher::Exact {
> +                        field: "type".into(),
> +                        values: vec!["prune".into()],
> +                    }.into()
> +                ),
> +                all_of![
> +                    FieldMatcher::Exact {
> +                        field: "type".into(),
> +                        values: vec!["prune".into()],
> +                    }.into(),
> +                    SeverityMatcher {
> +                        severities: vec![Severity::Error, Severity::Warning, Severity::Notice],

This is more of a question than actual feedback, I think, but how likely
is it that additional severity levels could be added in the future?
Because the old default matcher was
not(type == prune AND severity == info), whereas this specifically
matches a list of severities that would need to be extended to remain
equivalent, no?

In any case, couldn't this simply be

```
let expression = not!(all_of![
	FieldMatcher::Exact {
		field: "type".into(),
		values: vec!["prune".into()],
	}.into(),
	SeverityMatcher {
		severities: vec![Severity::Info],
	}.into(),
]);
```

to be equivalent to the old one? Or is there a reason this is not the
case?

> +                    }.into(),
> +                ],
> +            ];
> +
> +            let expression = serde_json::to_string(&expression)
> +                .expect("failed serialize expression for 'default-matcher'");
> +
> +            config
> +                .set_data(
> +                    "default-matcher",
> +                    MATCHER_TYPENAME,
> +                    MatcherConfig {
> +                        name: "default-matcher".into(),

[snip]