Re: [PATCH docs/guest-common/qemu-server v4 0/7] add new pci passthrough specific hookscript phase

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

It seems like there are no more additional reviews coming, so here is
my verdict.

I followed similar testing idiology as Jakob in [3] and came to the same
conclusion with 2 small notes:

1. disarm the example hookscript [0] by downgrading `die` to `warn`.

   This avoids current hookscripts dying should a new phase with 
   `stop_on_error=1` be introduced.

2. nit regarding redundant comment in [1].

So consider this:

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

[0] https://git.proxmox.com/?p=pve-docs.git;a=blob;f=examples/guest-example-hookscript.pl
[1] https://lore.proxmox.com/pve-devel/DL5JP1DEST4H.1CK8T93J8T97T@proxmox.com/
[3] https://lore.proxmox.com/pve-devel/DL5JZAB7ZY1O.261WNTEKI1S5K@proxmox.com/

On Tue Aug 25, 2026 at 3:54 PM CEST, Dominik Csapak wrote:
> this series adds a new phase to the guest hookscript that is called for each
> passed throug pci device after it's prepared, but before the qemu process is
> started.
>
> See the last qemu-server commit for why that is interesting.
>
> changes from v4:
> * rebase on current master
> * fix `local %ENV` clearing the whole environment instead of
>   just shadowing it, so the hookscript keeps the inherited environment
> * split the uuid handling out of the refactoring commit
> * call the hookscript once for both the mdev and the plain passthrough
>   case instead of duplicating the call in both branches
> * add missing `use PVE::GuestHelpers;`
> * move the new phase before 'post-start' to match the actual call
>   order, document that PVE_HOOK_MDEV_UUID is only set for mdevs, and
>   mention what the phase is useful for
> * fix typos
>
> changes from v3:
> * split unrelated logic/refactoring changes out to their own patches
> * fix typos
>
> changes from v2:
> * rebase on current master
> * prefix hook script env variables with 'PVE_HOOK_'
>
>
> pve-guest-common:
>
> Dominik Csapak (1):
>   helpers: exec hookscript: add optional parameters
>
>  src/PVE/GuestHelpers.pm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
>
> qemu-server:
>
> Dominik Csapak (5):
>   pci: mdev preparation: always generate local uuid first
>   pci: nvidia vgpu: correct wrong comment about uuid
>   pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module
>   pci: preparation: mdev: only generate uuid once
>   pci: call hookscript for each prepared pci device
>
>  src/PVE/QemuServer.pm     | 45 ++++++---------------------------
>  src/PVE/QemuServer/PCI.pm | 52 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 60 insertions(+), 37 deletions(-)
>
>
> pve-docs:
>
> Dominik Csapak (1):
>   examples: add new hookscript phase to example hookscript
>
>  examples/guest-example-hookscript.pl | 29 ++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
>
> Summary over all repositories:
>   4 files changed, 100 insertions(+), 38 deletions(-)