From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v4 3/7] pci: nvidia vgpu: correct wrong comment about uuid
Date: Tue, 25 Aug 2026 15:54:48 +0200 [thread overview]
Message-ID: <20260825135502.3971930-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260825135502.3971930-1-d.csapak@proxmox.com>
At the time the mdev code was written, it was believed that the uuid of
the qemu vm has to be the same as the mdev. This is obviously not true,
since we already prefer the smbios uuid, and if more than one vGPU is
given to a VM, this can't hold.
So the comment must be wrong, and the nvidia driver simply expects *a*
uuid, not the one of the mdev.
Also, it's not named NVIDIA GRID anymore, so use the current vGPU
terminology.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index ff916667..9c4c13b9 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -5726,7 +5726,7 @@ sub vm_start_nolock {
next if !$d->{mdev} && !$d->{nvidia};
die "could not create mediated device\n" if !defined($chosen_mdev);
- # nvidia grid needs the uuid of the mdev as qemu parameter
+ # nvidia vgpu needs a uuid as qemu parameter
if (!defined($uuid) && $chosen_mdev->{vendor} =~ m/^(0x)?10de$/) {
$uuid = PVE::QemuServer::PCI::Mdev::generate_mdev_uuid($vmid, $index);
}
--
2.47.3
next prev parent reply other threads:[~2026-08-25 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 13:54 [PATCH docs/guest-common/qemu-server v4 0/7] add new pci passthrough specific hookscript phase Dominik Csapak
2026-08-25 13:54 ` [PATCH guest-common v4 1/7] helpers: exec hookscript: add optional parameters Dominik Csapak
2026-08-25 13:54 ` [PATCH qemu-server v4 2/7] pci: mdev preparation: always generate local uuid first Dominik Csapak
2026-08-25 13:54 ` Dominik Csapak [this message]
2026-08-25 13:54 ` [PATCH qemu-server v4 4/7] pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module Dominik Csapak
2026-08-25 13:54 ` [PATCH qemu-server v4 5/7] pci: preparation: mdev: only generate uuid once Dominik Csapak
2026-08-25 13:54 ` [PATCH qemu-server v4 6/7] pci: call hookscript for each prepared pci device Dominik Csapak
2026-08-25 13:54 ` [PATCH docs v4 7/7] examples: add new hookscript phase to example hookscript Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825135502.3971930-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox