Re: [PATCH docs/guest-common/qemu-server v4 0/7] add new pci passthrough specific hookscript phase

[Dominik Csapak <d.csapak@proxmox.com>]

On 8/25/26 3:54 PM, Dominik Csapak wrote:
> this series adds a new phase to the guest hookscript that is called for each
> passed throug pci device after it's prepared, but before the qemu process is
> started.
> 
> See the last qemu-server commit for why that is interesting.
> 
> changes from v4:
> * rebase on current master
> * fix `local %ENV` clearing the whole environment instead of
>    just shadowing it, so the hookscript keeps the inherited environment
> * split the uuid handling out of the refactoring commit
> * call the hookscript once for both the mdev and the plain passthrough
>    case instead of duplicating the call in both branches
> * add missing `use PVE::GuestHelpers;`
> * move the new phase before 'post-start' to match the actual call
>    order, document that PVE_HOOK_MDEV_UUID is only set for mdevs, and
>    mention what the phase is useful for
> * fix typos
> 
> changes from v3:
> * split unrelated logic/refactoring changes out to their own patches
> * fix typos
> 

not sure what i was thinking yesterday, of course these two
'changes from v3/v4' are both meant as 'changes from v3'

(i guess i started writing, paused, and finished later with
mindlessly adding a new section....)

> changes from v2:
> * rebase on current master
> * prefix hook script env variables with 'PVE_HOOK_'
> 
> 
> pve-guest-common:
> 
> Dominik Csapak (1):
>    helpers: exec hookscript: add optional parameters
> 
>   src/PVE/GuestHelpers.pm | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
> 
> qemu-server:
> 
> Dominik Csapak (5):
>    pci: mdev preparation: always generate local uuid first
>    pci: nvidia vgpu: correct wrong comment about uuid
>    pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module
>    pci: preparation: mdev: only generate uuid once
>    pci: call hookscript for each prepared pci device
> 
>   src/PVE/QemuServer.pm     | 45 ++++++---------------------------
>   src/PVE/QemuServer/PCI.pm | 52 +++++++++++++++++++++++++++++++++++++++
>   2 files changed, 60 insertions(+), 37 deletions(-)
> 
> 
> pve-docs:
> 
> Dominik Csapak (1):
>    examples: add new hookscript phase to example hookscript
> 
>   examples/guest-example-hookscript.pl | 29 ++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> 
> Summary over all repositories:
>    4 files changed, 100 insertions(+), 38 deletions(-)
>