Re: [PATCH guest-common v4 1/7] helpers: exec hookscript: add optional parameters

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

Good change.

1 small nit inline.

On Tue Aug 25, 2026 at 3:54 PM CEST, Dominik Csapak wrote:

[...]

>  
>  sub exec_hookscript {
> -    my ($conf, $vmid, $phase, $stop_on_error) = @_;
> +    my ($conf, $vmid, $phase, $stop_on_error, $params) = @_;
>  
>      return if !$conf->{hookscript};
>  
> +    $params //= {};
> +
>      eval {
>          my $hookscript = check_hookscript($conf->{hookscript});
>          die $@ if $@;
>  
> +        # copy EVN before adding to it

nit: I would prefer a comment that explains why we need this line
instead of what it does.

e.g. something like

# do not clear global ENV: hookscript keeps inherited ENV

> +        local %ENV = (%ENV);
> +
> +        for my $key (keys $params->%*) {
> +            my $new_key = "PVE_HOOK_" . uc($key);
> +            $ENV{$new_key} = $params->{$key};
> +        }
> +
>          PVE::Tools::run_command([$hookscript, $vmid, $phase]);
>      };
>      if (my $err = $@) {