public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH-SERIES ha-manager/manager 0/3] fix #7557: introduce 'auto-rebalance' property
Date: Tue, 12 May 2026 13:53:35 +0200	[thread overview]
Message-ID: <DIGOEN9DL2N5.456KBFBX3FOQ@proxmox.com> (raw)
In-Reply-To: <DIGL6E05PQ0P.32RU2R4OO94Z3@proxmox.com>

thx for testing the series

On Tue May 12, 2026 at 11:21 AM CEST, Daniel Kral wrote:
> On Mon May 11, 2026 at 5:57 PM CEST, Dominik Rusovac wrote:
>> # TL;DR 
>> Add 'auto-rebalance' property to HA resources config, which gives users
>> control over which HA resources may be moved by dynamic CRS during
>> automatic rebalancing.
>>
>> # Details
>> The 'auto-rebalance' flag is set to true by default. As requested by [0],
>> disabling 'auto-rebalance' for some HA resource, say vm:100, means that vm:100
>> will be disregarded as a migration candidate during auto-rebalancing. Any HA
>> resource with a positive affinity for vm:100 will be disregarded too.
>>
>> # Summary of Changes
>> This series:
>> - introduces property to control whether an HA resource may be migrated during
>>   automatic rebalancing;
>> - adds corresponding flag to PVE UI.
>>
>> # Refs
>> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=7557
>
> Tested the series and it works just as expected:
>
> - only a single HA resource with auto-rebalance cleared; set
>   imbalance-threshold to 0.1 and imbalance-margin to 0.05, put no load
>   on node3, some load on node2 and a lot of load with a non-HA VM and
>   the HA resource from above, but it was never moved to the other nodes;
>   it was moved to node3 as soon as I set auto-rebalance again
>
> - tested the same with a positive resource affinity rule with that HA
>   resource and another new HA resource and they never moved away unless
>   I set the auto-rebalance option for all again
>
> Nice work, thanks for the quick patch series!
>
> Would be great to document this in the documentation as well so users
> are aware especially that if such HA resources are in a resource
> affinity rule, that they make the whole resource bundle immovable. But
> this can also be done as a follow-up.

I will take care of the docs in a follow-up

>
> Consider this as:
>
> Tested-by: Daniel Kral <d.kral@proxmox.com>





      reply	other threads:[~2026-05-12 11:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 15:57 [PATCH-SERIES ha-manager/manager 0/3] fix #7557: introduce 'auto-rebalance' property Dominik Rusovac
2026-05-11 15:57 ` [PATCH pve-manager 1/3] ui: ha: add auto-rebalance flag Dominik Rusovac
2026-05-12  9:05   ` Daniel Kral
2026-05-11 15:57 ` [PATCH pve-ha-manager 2/3] manager: set service config value in self Dominik Rusovac
2026-05-12  9:06   ` Daniel Kral
2026-05-12 11:55     ` Dominik Rusovac
2026-05-11 15:57 ` [PATCH pve-ha-manager 3/3] fix #7557: introduce 'auto-rebalance' property Dominik Rusovac
2026-05-12  9:07   ` Daniel Kral
2026-05-12 11:51     ` Dominik Rusovac
2026-05-12  9:21 ` [PATCH-SERIES ha-manager/manager 0/3] " Daniel Kral
2026-05-12 11:53   ` Dominik Rusovac [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIGOEN9DL2N5.456KBFBX3FOQ@proxmox.com \
    --to=d.rusovac@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal