Re: [PATCH pve-manager 1/3] ui: ha: add auto-rebalance flag

["Daniel Kral" <d.kral@proxmox.com>]

Looks good to me, a small unrelated (pre-existing) nit inline, in any
way consider this as:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>

On Mon May 11, 2026 at 5:57 PM CEST, Dominik Rusovac wrote:
> Adapt the implementation of the 'failback' flag for the 'auto-rebalance'
> flag, which controls whether an HA resource is allowed to migrate during
> automatic rebalancing.
>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
>  www/manager6/ha/ResourceEdit.js | 14 ++++++++++++++
>  www/manager6/ha/Resources.js    |  6 ++++++
>  www/manager6/ha/StatusView.js   |  4 ++++
>  3 files changed, 24 insertions(+)
>
> diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js
> index a4f53dad..487d9cf3 100644
> --- a/www/manager6/ha/ResourceEdit.js
> +++ b/www/manager6/ha/ResourceEdit.js
> @@ -12,6 +12,7 @@ Ext.define('PVE.ha.VMResourceInputPanel', {
>          delete values.vmid;
>  
>          PVE.Utils.delete_if_default(values, 'failback', '1', me.isCreate);
> +        PVE.Utils.delete_if_default(values, 'auto-rebalance', '1', me.isCreate);
>          PVE.Utils.delete_if_default(values, 'max_restart', '1', me.isCreate);
>          PVE.Utils.delete_if_default(values, 'max_relocate', '1', me.isCreate);
>  
> @@ -123,6 +124,19 @@ Ext.define('PVE.ha.VMResourceInputPanel', {
>                  uncheckedValue: 0,
>                  value: 1,
>              },
> +            {
> +                xtype: 'proxmoxcheckbox',
> +                name: 'auto-rebalance',
> +                fieldLabel: gettext('Auto-Rebalance'),
> +                autoEl: {
> +                    tag: 'div',
> +                    'data-qtip': gettext(
> +                        'Enable if HA resource may be migrated during automatic rebalancing.',
> +                    ),
> +                },
> +                uncheckedValue: 0,
> +                value: 1,
> +            },

nit: pre-existing, but maybe I think it might be nice to move the
requested state to the top row (in a patch before this) as it seems more
central to the HA resources than the 'failback' and new 'auto-rebalance'
option. No hard feelings though for this and definitely shouldn't block
this series at all.

>              {
>                  xtype: 'proxmoxKVComboBox',
>                  name: 'state',
> diff --git a/www/manager6/ha/Resources.js b/www/manager6/ha/Resources.js
> index 621ed336..2fda3b24 100644
> --- a/www/manager6/ha/Resources.js
> +++ b/www/manager6/ha/Resources.js
> @@ -150,6 +150,12 @@ Ext.define('PVE.ha.ResourcesView', {
>                      sortable: true,
>                      dataIndex: 'failback',
>                  },
> +                {
> +                    header: gettext('Auto-Rebalance'),
> +                    width: 100,
> +                    sortable: true,
> +                    dataIndex: 'auto-rebalance',
> +                },
>                  {
>                      header: gettext('Description'),
>                      flex: 1,
> diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js
> index bc2da71f..59fcc6f3 100644
> --- a/www/manager6/ha/StatusView.js
> +++ b/www/manager6/ha/StatusView.js
> @@ -84,6 +84,10 @@ Ext.define(
>                      name: 'failback',
>                      type: 'boolean',
>                  },
> +                {
> +                    name: 'auto-rebalance',
> +                    type: 'boolean',
> +                },
>                  'max_restart',
>                  'max_relocate',
>                  'type',