From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F03861FF146 for ; Tue, 12 May 2026 13:53:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B6CB910AC1; Tue, 12 May 2026 13:53:41 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 12 May 2026 13:53:35 +0200 Message-Id: Subject: Re: [PATCH-SERIES ha-manager/manager 0/3] fix #7557: introduce 'auto-rebalance' property From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260511155734.149101-1-d.rusovac@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778586703500 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.356 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QWUP5GBF2BBO35C6AZGSIOYSLOALM7UC X-Message-ID-Hash: QWUP5GBF2BBO35C6AZGSIOYSLOALM7UC X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: thx for testing the series On Tue May 12, 2026 at 11:21 AM CEST, Daniel Kral wrote: > On Mon May 11, 2026 at 5:57 PM CEST, Dominik Rusovac wrote: >> # TL;DR=20 >> Add 'auto-rebalance' property to HA resources config, which gives users >> control over which HA resources may be moved by dynamic CRS during >> automatic rebalancing. >> >> # Details >> The 'auto-rebalance' flag is set to true by default. As requested by [0]= , >> disabling 'auto-rebalance' for some HA resource, say vm:100, means that = vm:100 >> will be disregarded as a migration candidate during auto-rebalancing. An= y HA >> resource with a positive affinity for vm:100 will be disregarded too. >> >> # Summary of Changes >> This series: >> - introduces property to control whether an HA resource may be migrated = during >> automatic rebalancing; >> - adds corresponding flag to PVE UI. >> >> # Refs >> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=3D7557 > > Tested the series and it works just as expected: > > - only a single HA resource with auto-rebalance cleared; set > imbalance-threshold to 0.1 and imbalance-margin to 0.05, put no load > on node3, some load on node2 and a lot of load with a non-HA VM and > the HA resource from above, but it was never moved to the other nodes; > it was moved to node3 as soon as I set auto-rebalance again > > - tested the same with a positive resource affinity rule with that HA > resource and another new HA resource and they never moved away unless > I set the auto-rebalance option for all again > > Nice work, thanks for the quick patch series! > > Would be great to document this in the documentation as well so users > are aware especially that if such HA resources are in a resource > affinity rule, that they make the whole resource bundle immovable. But > this can also be done as a follow-up. I will take care of the docs in a follow-up > > Consider this as: > > Tested-by: Daniel Kral