From: Christoph Heiss <c.heiss@proxmox.com>
To: Lukas Sichert <l.sichert@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH installer 15/15] tui: network: add bond setup options to advanced network dialog
Date: Fri, 23 Oct 2026 11:32:22 +0200 [thread overview]
Message-ID: <9a568339-3f00-48f5-8bbd-82ba66d146f5@proxmox.com> (raw)
In-Reply-To: <DMBHBF2LQV1S.2R6QLLSI7SL59@proxmox.com>
Thanks for the review!
On 10/22/26 17:40, Lukas Sichert wrote:
> The TUI also looks good. Just one problem inline:
> [..]
> The forms first child gets added with
>
> .child(
> "Management interface",
> iface_selection.with_name(Self::MGMT_IFNAME_SELECTVIEW_NAME),
> )
>
> which is of type NamedView<SelectView<Interface>>. But gets replaced
> with the output of build_mgmt_ifname_selectview, which is of type
> SelectView<Interface>. In the preview, when opening the advanced
> menu and hitting Ok without changing anything, I get the error message
> 'Invalid values: failed to retrieve management interface name'.
Good catch! I'll fix it for v3.
(On a related note: While the typesafe interface of cursive is great,
sometimes - in situations like this - it can also be bit of PITA, tbh.)
next prev parent reply other threads:[~2026-10-23 9:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 11:23 [PATCH installer/proxmox 00/15] partially fix #2164: add bond setup across all installers Christoph Heiss
2026-10-20 11:23 ` [PATCH proxmox 01/15] installer-types: use `MacAddress` type where applicable Christoph Heiss
2026-10-20 11:23 ` [PATCH proxmox 02/15] installer-types: answer: add options for configuring management bond Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 03/15] install: run make tidy Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 04/15] tree-wide: use `MacAddress` type instead of string for MAC addresses Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 05/15] install: factor out /etc/network/interfaces setup into own subroutine Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 06/15] install: do not rely on interface name map to be fully populated Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 07/15] install: config: add option for setting up bond on management interface Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 08/15] install: network: set up management bond if requested Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 09/15] gui: network: factor out name pinning into advanced options dialog Christoph Heiss
2026-10-21 14:12 ` Lukas Sichert
2026-10-20 11:23 ` [PATCH installer 10/15] gui: network: add bond setup options to " Christoph Heiss
2026-10-21 15:36 ` Lukas Sichert
2026-10-21 15:46 ` Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 11/15] auto: pass trough management network bond options to low-level installer Christoph Heiss
2026-10-21 15:52 ` Lukas Sichert
2026-10-20 11:23 ` [PATCH installer 12/15] tui: drop long obsolete comment about logo formatting Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 13/15] tui: views: add widget for displaying a group of checkboxes Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 14/15] tui: network: factor out name pinning into advanced options dialog Christoph Heiss
2026-10-22 15:45 ` Lukas Sichert
2026-10-22 16:16 ` Lukas Sichert
2026-10-20 11:23 ` [PATCH installer 15/15] tui: network: add bond setup options to advanced network dialog Christoph Heiss
2026-10-22 15:40 ` Lukas Sichert
2026-10-23 9:32 ` Christoph Heiss [this message]
2026-10-20 11:25 ` [PATCH installer/proxmox 00/15] partially fix #2164: add bond setup across all installers Christoph Heiss
-- strict thread matches above, loose matches on Subject: below --
2026-09-08 10:16 Christoph Heiss
2026-09-08 10:16 ` [PATCH installer 15/15] tui: network: add bond setup options to advanced network dialog Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a568339-3f00-48f5-8bbd-82ba66d146f5@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox