From: "Lukas Sichert" <l.sichert@proxmox.com>
To: "Christoph Heiss" <c.heiss@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH installer 14/15] tui: network: factor out name pinning into advanced options dialog
Date: Thu, 22 Oct 2026 18:16:23 +0200 [thread overview]
Message-ID: <DMBI2NQAMMPQ.1HDHVDNQSUYQQ@proxmox.com> (raw)
In-Reply-To: <20261020112327.641633-15-c.heiss@proxmox.com>
On 2026-10-20 13:23, Christoph Heiss <c.heiss@proxmox.com> wrote:
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> + Dialog::around(inner)
> + .title("Advanced Network Options")
> + .button("Ok", {
> + move |siv| {
> + match Self::get_view_values(siv) {
> + Ok(pin_opts) => {
> + siv.pop_layer();
> + let options = &mut options_ref.lock().expect("unpoisoned lock");
> + options.pinning_options = pin_opts;
> + }
> + Err(err) => {
> + siv.pop_layer();
> + siv.add_layer(Dialog::info(err.to_string()));
> + return;
> + }
> }
Nit: In case of Error I don't think the advanced options dialog should
be deleted. The pop_layer call gets deleted in the next commit anyways,
hence nit only.
next prev parent reply other threads:[~2026-10-22 16:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 11:23 [PATCH installer/proxmox 00/15] partially fix #2164: add bond setup across all installers Christoph Heiss
2026-10-20 11:23 ` [PATCH proxmox 01/15] installer-types: use `MacAddress` type where applicable Christoph Heiss
2026-10-20 11:23 ` [PATCH proxmox 02/15] installer-types: answer: add options for configuring management bond Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 03/15] install: run make tidy Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 04/15] tree-wide: use `MacAddress` type instead of string for MAC addresses Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 05/15] install: factor out /etc/network/interfaces setup into own subroutine Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 06/15] install: do not rely on interface name map to be fully populated Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 07/15] install: config: add option for setting up bond on management interface Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 08/15] install: network: set up management bond if requested Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 09/15] gui: network: factor out name pinning into advanced options dialog Christoph Heiss
2026-10-21 14:12 ` Lukas Sichert
2026-10-20 11:23 ` [PATCH installer 10/15] gui: network: add bond setup options to " Christoph Heiss
2026-10-21 15:36 ` Lukas Sichert
2026-10-21 15:46 ` Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 11/15] auto: pass trough management network bond options to low-level installer Christoph Heiss
2026-10-21 15:52 ` Lukas Sichert
2026-10-20 11:23 ` [PATCH installer 12/15] tui: drop long obsolete comment about logo formatting Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 13/15] tui: views: add widget for displaying a group of checkboxes Christoph Heiss
2026-10-20 11:23 ` [PATCH installer 14/15] tui: network: factor out name pinning into advanced options dialog Christoph Heiss
2026-10-22 15:45 ` Lukas Sichert
2026-10-22 16:16 ` Lukas Sichert [this message]
2026-10-20 11:23 ` [PATCH installer 15/15] tui: network: add bond setup options to advanced network dialog Christoph Heiss
2026-10-22 15:40 ` Lukas Sichert
2026-10-20 11:25 ` [PATCH installer/proxmox 00/15] partially fix #2164: add bond setup across all installers Christoph Heiss
-- strict thread matches above, loose matches on Subject: below --
2026-09-08 10:16 Christoph Heiss
2026-09-08 10:16 ` [PATCH installer 14/15] tui: network: factor out name pinning into advanced options dialog Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMBI2NQAMMPQ.1HDHVDNQSUYQQ@proxmox.com \
--to=l.sichert@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox