From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 4F1171FF0EC
	for <inbox@lore.proxmox.com>; Thu, 22 Oct 2026 18:16:31 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id F1A652166F;
	Thu, 22 Oct 2026 18:16:26 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 22 Oct 2026 18:16:23 +0200
Message-Id: <DMBI2NQAMMPQ.1HDHVDNQSUYQQ@proxmox.com>
Subject: Re: [PATCH installer 14/15] tui: network: factor out name pinning
 into advanced options dialog
From: "Lukas Sichert" <l.sichert@proxmox.com>
To: "Christoph Heiss" <c.heiss@proxmox.com>, <pve-devel@lists.proxmox.com>
References: <20261020112327.641633-1-c.heiss@proxmox.com>
 <20261020112327.641633-15-c.heiss@proxmox.com>
In-Reply-To: <20261020112327.641633-15-c.heiss@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1792685783589
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.582 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: UXXGTMFU5FIMAP7MQPGVVWSP4FYOQYXG
X-Message-ID-Hash: UXXGTMFU5FIMAP7MQPGVVWSP4FYOQYXG
X-MailFrom: l.sichert@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On 2026-10-20 13:23, Christoph Heiss <c.heiss@proxmox.com> wrote:

> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> +        Dialog::around(inner)
> +            .title("Advanced Network Options")
> +            .button("Ok", {
> +                move |siv| {
> +                    match Self::get_view_values(siv) {
> +                        Ok(pin_opts) =3D> {
> +                            siv.pop_layer();
> +                            let options =3D &mut options_ref.lock().expe=
ct("unpoisoned lock");
> +                            options.pinning_options =3D pin_opts;
> +                        }
> +                        Err(err) =3D> {
> +                            siv.pop_layer();
> +                            siv.add_layer(Dialog::info(err.to_string()))=
;
> +                            return;
> +                        }
>                      }


Nit: In case of Error I don't think the advanced options dialog should
be deleted. The pop_layer call gets deleted in the next commit anyways,
hence nit only.