Re: [PATCH installer 15/15] tui: network: add bond setup options to advanced network dialog

["Lukas Sichert" <l.sichert@proxmox.com>]

The TUI also looks good. Just one problem inline:

On 2026-10-20 13:23, Christoph Heiss <c.heiss@proxmox.com> wrote:



> +    fn refresh_ifname_view(siv: &mut Cursive, options_ref: NetworkViewOptionsRef) {
> +        siv.call_on_name(Self::FORM_VIEW_NAME, |form: &mut FormView<()>| {
> +            let options = options_ref.lock().expect("unpoisoned lock");
> +
> +            if options.bond_enabled {
> +                form.replace_child(
> +                    0,
> +                    TextView::new(format!(
> +                        "bond0 (mode: {}, {} members)",
> +                        options.bond_options.mode,
> +                        options.bond_options.members.len()
> +                    )),
> +                );
> +            } else {
> +                drop(options);
> +                form.replace_child(0, Self::build_mgmt_ifname_selectview(options_ref.clone()));
> +            }
> +        });
>      }



> -    fn build_mgmt_ifname_selectview(
> -        options_ref: NetworkViewOptionsRef,
> -        selected_mac: Option<MacAddress>,
> -    ) -> SelectView<Interface> {


The forms first child gets added with

    .child(
                "Management interface",
                iface_selection.with_name(Self::MGMT_IFNAME_SELECTVIEW_NAME),
            )

which is of type NamedView<SelectView<Interface>>. But gets replaced
with the output of build_mgmt_ifname_selectview, which is of type
SelectView<Interface>. In the preview, when opening the advanced
menu and hitting Ok without changing anything, I get the error message
'Invalid values: failed to retrieve management interface name'.