From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id C0D831FF0B0
	for <inbox@lore.proxmox.com>; Fri, 23 Oct 2026 11:32:25 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 8423E21621;
	Fri, 23 Oct 2026 11:32:25 +0200 (CEST)
Message-ID: <9a568339-3f00-48f5-8bbd-82ba66d146f5@proxmox.com>
Date: Fri, 23 Oct 2026 11:32:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH installer 15/15] tui: network: add bond setup options to
 advanced network dialog
To: Lukas Sichert <l.sichert@proxmox.com>
References: <20261020112327.641633-1-c.heiss@proxmox.com>
 <20261020112327.641633-16-c.heiss@proxmox.com>
 <DMBHBF2LQV1S.2R6QLLSI7SL59@proxmox.com>
Content-Language: en-US
From: Christoph Heiss <c.heiss@proxmox.com>
In-Reply-To: <DMBHBF2LQV1S.2R6QLLSI7SL59@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1792747942294
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.238 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: HUZGFCS2ZBTKGWCXJ3FI3CKFEO375FKG
X-Message-ID-Hash: HUZGFCS2ZBTKGWCXJ3FI3CKFEO375FKG
X-MailFrom: c.heiss@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Thanks for the review!

On 10/22/26 17:40, Lukas Sichert wrote:
> The TUI also looks good. Just one problem inline:
> [..]
> The forms first child gets added with
> 
>      .child(
>                  "Management interface",
>                  iface_selection.with_name(Self::MGMT_IFNAME_SELECTVIEW_NAME),
>              )
> 
> which is of type NamedView<SelectView<Interface>>. But gets replaced
> with the output of build_mgmt_ifname_selectview, which is of type
> SelectView<Interface>. In the preview, when opening the advanced
> menu and hitting Ok without changing anything, I get the error message
> 'Invalid values: failed to retrieve management interface name'.

Good catch! I'll fix it for v3.

(On a related note: While the typesafe interface of cursive is great, 
sometimes - in situations like this - it can also be bit of PITA, tbh.)