* [PATCH manager] ui: backup storage selector: match complete node names
@ 2026-11-07 19:38 Samir Hanna Verza
0 siblings, 0 replies; only message in thread
From: Samir Hanna Verza @ 2026-11-07 19:38 UTC (permalink / raw)
To: pve-devel
The cluster-wide storage endpoint returns a comma-separated node list.
Checking it as a string makes a storage restricted to pve10 appear in
the backup storage picker for pve1. The job cannot activate that
storage when it runs on pve1.
Split the list before testing membership. Keep unrestricted storages
and the existing content and disabled filters.
The selector fixture fails on the prefix and suffix cases before this
change. It passes for exact names, multi-node lists, and All nodes
afterward. The fixture uses the production selector methods and a
mocked store.
Bugzilla: https://bugzilla.proxmox.com/show_bug.cgi?id=8303
Signed-off-by: Samir Hanna Verza <samir@blue3.com.br>
---
| 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--git a/www/manager6/form/StorageSelector.js b/www/manager6/form/StorageSelector.js
index 0b5e10da..bcf0bb05 100644
--- a/www/manager6/form/StorageSelector.js
+++ b/www/manager6/form/StorageSelector.js
@@ -87,10 +87,10 @@ Ext.define(
}
if (me.nodename) {
- filters.push(
- (storage) =>
- !storage.data.nodes || storage.data.nodes.includes(me.nodename),
- );
+ filters.push((storage) => {
+ let nodes = storage.data.nodes;
+ return !nodes || nodes.split(',').includes(me.nodename);
+ });
}
me.getStore().clearFilter();
base-commit: a5355c34dea5e9b1d616788a150f08f3a520a575
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-09 8:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-07 19:38 [PATCH manager] ui: backup storage selector: match complete node names Samir Hanna Verza
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox